From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EC9F41C26; Tue, 7 Feb 2023 01:19:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C55242B7E; Tue, 7 Feb 2023 01:19:45 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 3D492410DF for ; Tue, 7 Feb 2023 01:19:42 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id d6-20020a17090ae28600b00230aa72904fso4952887pjz.5 for ; Mon, 06 Feb 2023 16:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g0/Coq6lKl4MtVHLviOM6p7pAIVfLbixpN4VxI/gtdc=; b=c7d1AairKyoLsI3Gbg6glyRBexKXcPHwfSb5gwvi+mormlV1iDJQ8BtFNtRFgdm2c4 SlOFKaObu9yfzK8fRwDg7vShBT/xd5wxXOtI+WjJrDQVc6j2ulO++9uDc/yQsYhuUwsM nmbEJzzxaKdRNhRx29zOjchGc3fPGiRpBzULAqovbUIOYIBRveWL9ltYptfGYNV6PvYo kcywY97enmhH1As85wplBbjgaZQxhfYLUij5wFv2BJ7XhPmO8/m7Rbtmv0mcf818ezla g2D8cam7y6PuUyrwAPs/EuyzwERYzdoWyk3S4PFkE8cAG5QKFslVQoTOL87eMqWFj1MK s2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0/Coq6lKl4MtVHLviOM6p7pAIVfLbixpN4VxI/gtdc=; b=Vuvb3hKfg54+qnT1pyDHE54r4lCHCj4as69DLq1rRSE5qVKuvjT9DwfY+YBKPFfH7X 4uE9808bJacDwWlCNXR41jRBdpayYc0D+1v89Gn67wMerL2f2S9OcaIEFjNipM0f3W/J 14pyeVEJLBhyqx0cgj6VOC86TXXe0+8XRxNK2NHTJSWPNfEd1UrFY9UpBCcXEdCJ6tIA nSeqM+hK+LJmZB+Gad2oHZieAHVMPGqD5GzlRE/qGBDCsBaJloFsRrEa9kBRoK5nQWTZ pKwBDGaNbmRcVLqc02QC9xK4qEJFZ0JlcdxgvdNJq066vCzuclYWZeE/mT3j+92KI0O8 FnDA== X-Gm-Message-State: AO0yUKUMVugI9gIGhQ6tz4cRjWw4WQvVPvDIF1BsCpdrn5J9yc4ZY2/B Kd9cMgvn46Dsl2AGFzl8CVzFkqJksNAo3pr+w5M= X-Google-Smtp-Source: AK7set9+2kDwwlY9iS30Dqk8TsYWS6mkcv7V0OcdRuHK7DttxlVjVh+LXfahpWPq/JlSiM07x5rQPg== X-Received: by 2002:a05:6a20:394e:b0:bf:7ae0:5f97 with SMTP id r14-20020a056a20394e00b000bf7ae05f97mr1510889pzg.21.1675729181046; Mon, 06 Feb 2023 16:19:41 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id o11-20020a637e4b000000b0046ff3634a78sm6617393pgn.71.2023.02.06.16.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 16:19:40 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , Bruce Richardson Subject: [PATCH v2 2/8] net/ring: build on Windows Date: Mon, 6 Feb 2023 16:19:31 -0800 Message-Id: <20230207001937.875608-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230207001937.875608-1-stephen@networkplumber.org> References: <20221201014440.11896-1-stephen@networkplumber.org> <20230207001937.875608-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The command line arguments are stored in node_action_pair and the name[] was sized to PATH_MAX which does not exist on Windows. Since the name is either "CREATE" or "ATTACH" it is not related to PATH_MAX (4096). With this fix driver builds ok on windows, but need to modify the test meson build to skip the eventdev test on Windows. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- app/test/meson.build | 2 +- drivers/net/ring/meson.build | 6 ------ drivers/net/ring/rte_eth_ring.c | 3 ++- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index f34d19e3c3cb..a713f0382280 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -390,7 +390,7 @@ if dpdk_conf.has('RTE_NET_BOND') driver_test_names += 'link_bonding_mode4_autotest' endif endif -if dpdk_conf.has('RTE_NET_RING') +if dpdk_conf.has('RTE_LIB_EVENTDEV') and dpdk_conf.has('RTE_NET_RING') test_deps += 'net_ring' test_sources += 'test_pmd_ring_perf.c' test_sources += 'test_pmd_ring.c' diff --git a/drivers/net/ring/meson.build b/drivers/net/ring/meson.build index 72792e26b05a..3534a3cc2287 100644 --- a/drivers/net/ring/meson.build +++ b/drivers/net/ring/meson.build @@ -1,12 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation -if is_windows - build = false - reason = 'not supported on Windows' - subdir_done() -endif - sources = files('rte_eth_ring.c') headers = files('rte_eth_ring.h') pmd_supports_disable_iova_as_pa = true diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index bd5a47dd9017..564d6a726403 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -17,6 +17,7 @@ #define ETH_RING_NUMA_NODE_ACTION_ARG "nodeaction" #define ETH_RING_ACTION_CREATE "CREATE" #define ETH_RING_ACTION_ATTACH "ATTACH" +#define ETH_RING_ACTION_MAX_LEN 8 /* CREATE | ACTION */ #define ETH_RING_INTERNAL_ARG "internal" #define ETH_RING_INTERNAL_ARG_MAX_LEN 19 /* "0x..16chars..\0" */ @@ -539,7 +540,7 @@ eth_dev_ring_create(const char *name, } struct node_action_pair { - char name[PATH_MAX]; + char name[ETH_RING_ACTION_MAX_LEN]; unsigned int node; enum dev_action action; }; -- 2.39.1