From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] app/dumpcap: don't pass negative value to strerror() on error
Date: Tue, 7 Feb 2023 09:00:50 -0800 [thread overview]
Message-ID: <20230207170050.1093917-1-stephen@networkplumber.org> (raw)
If eth_stats_get fails (for example with -ENOTSUPP) then
dumpcap would pass that to strerror which is incorrect.
Fixes: 8744f84bb255 ("app/dumpcap: add statistics mode")
Coverity issue: 383136
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 904eb5a7d7d9..64294bbfb3e6 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -500,7 +500,7 @@ static void statistics_loop(void)
if (r < 0) {
fprintf(stderr,
"stats_get for port %u failed: %d (%s)\n",
- p, r, strerror(r));
+ p, r, strerror(-r));
return;
}
--
2.39.1
next reply other threads:[~2023-02-07 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 17:00 Stephen Hemminger [this message]
2023-02-19 17:50 ` Stephen Hemminger
2023-03-12 14:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207170050.1093917-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).