From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 44AE141C33;
Tue, 7 Feb 2023 20:38:08 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6947742D13;
Tue, 7 Feb 2023 20:37:51 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 364AA42670
for <dev@dpdk.org>; Tue, 7 Feb 2023 20:37:49 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1675798668;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=sUIaYtxK64a4+Pe43pleFN9m60Ys9Uhyd8DlUAo1V5k=;
b=Uzlxt/q7ZXmGqAeBcWvY2DLBJmrTLdFANvy9sz9AUCxJ8ZIxCDOT8rlRzdJ1ULEswH+5ZW
db6OwOaIGl9aXnKYRrPwBs/psDRayZFmY9UuMaEUDA8gehlsTIvxL4oqJBnKRjIH7M5YCw
BCPHDEVVunoYPxDwLOcex2qiFpvKvlo=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-121-8Op5OkrMNYKpwCvA8FqIOg-1; Tue, 07 Feb 2023 14:37:47 -0500
X-MC-Unique: 8Op5OkrMNYKpwCvA8FqIOg-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
[10.11.54.3])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 45D8F801779;
Tue, 7 Feb 2023 19:37:47 +0000 (UTC)
Received: from ringo.home (unknown [10.39.208.16])
by smtp.corp.redhat.com (Postfix) with ESMTP id 6F39F1121314;
Tue, 7 Feb 2023 19:37:46 +0000 (UTC)
From: Robin Jarry <rjarry@redhat.com>
To: dev@dpdk.org
Cc: Robin Jarry <rjarry@redhat.com>,
Kevin Laatz <kevin.laatz@intel.com>
Subject: [PATCH v9 5/5] eal: add lcore usage telemetry endpoint
Date: Tue, 7 Feb 2023 20:37:31 +0100
Message-Id: <20230207193731.1242505-6-rjarry@redhat.com>
In-Reply-To: <20221123102612.1688865-1-rjarry@redhat.com>
References: <20221123102612.1688865-1-rjarry@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"; x-default=true
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Allow fetching CPU cycles usage for all lcores with a single request.
This endpoint is intended for repeated and frequent invocations by
external monitoring systems and therefore returns condensed data.
It consists of a single dictionary with three keys: "lcore_ids",
"total_cycles" and "busy_cycles" that are mapped to three arrays of
integer values. Each array has the same number of values, one per lcore,
in the same order.
Example:
--> /eal/lcore/usage
{
"/eal/lcore/usage": {
"lcore_ids": [
4,
5
],
"total_cycles": [
23846845590,
23900558914
],
"busy_cycles": [
21043446682,
21448837316
]
}
}
Signed-off-by: Robin Jarry <rjarry@redhat.com>
Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
---
Notes:
v8 -> v9: Updated with 64 bits integer telemetry functions
doc/guides/rel_notes/release_23_03.rst | 5 ++-
lib/eal/common/eal_common_lcore.c | 60 ++++++++++++++++++++++++++
2 files changed, 63 insertions(+), 2 deletions(-)
diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst
index 17d38d5ea264..4f2878846829 100644
--- a/doc/guides/rel_notes/release_23_03.rst
+++ b/doc/guides/rel_notes/release_23_03.rst
@@ -57,8 +57,9 @@ New Features
* **Added support for reporting lcore usage in applications.**
- * The ``/eal/lcore/list`` and ``/eal/lcore/info`` telemetry endpoints have
- been added to provide information similar to ``rte_lcore_dump()``.
+ * The ``/eal/lcore/list``, ``/eal/lcore/usage`` and ``/eal/lcore/info``
+ telemetry endpoints have been added to provide information similar to
+ ``rte_lcore_dump()``.
* Applications can register a callback at startup via
``rte_lcore_register_usage_cb()`` to provide lcore usage information.
diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
index fcda7c50119a..088adb14b4b6 100644
--- a/lib/eal/common/eal_common_lcore.c
+++ b/lib/eal/common/eal_common_lcore.c
@@ -569,6 +569,63 @@ handle_lcore_info(const char *cmd __rte_unused, const char *params, struct rte_t
return rte_lcore_iterate(lcore_telemetry_info_cb, &info);
}
+struct lcore_telemetry_usage {
+ struct rte_tel_data *lcore_ids;
+ struct rte_tel_data *total_cycles;
+ struct rte_tel_data *busy_cycles;
+};
+
+static int
+lcore_telemetry_usage_cb(unsigned int lcore_id, void *arg)
+{
+ struct lcore_telemetry_usage *u = arg;
+ struct rte_lcore_usage usage;
+ rte_lcore_usage_cb usage_cb;
+
+ /* The callback may not set all the fields in the structure, so clear it here. */
+ memset(&usage, 0, sizeof(usage));
+ /* Guard against concurrent modification of lcore_usage_cb. */
+ usage_cb = lcore_usage_cb;
+ if (usage_cb != NULL && usage_cb(lcore_id, &usage) == 0) {
+ rte_tel_data_add_array_uint(u->lcore_ids, lcore_id);
+ rte_tel_data_add_array_uint(u->total_cycles, usage.total_cycles);
+ rte_tel_data_add_array_uint(u->busy_cycles, usage.busy_cycles);
+ }
+
+ return 0;
+}
+
+static int
+handle_lcore_usage(const char *cmd __rte_unused,
+ const char *params __rte_unused,
+ struct rte_tel_data *d)
+{
+ struct lcore_telemetry_usage usage;
+ struct rte_tel_data *lcore_ids = rte_tel_data_alloc();
+ struct rte_tel_data *total_cycles = rte_tel_data_alloc();
+ struct rte_tel_data *busy_cycles = rte_tel_data_alloc();
+
+ if (!lcore_ids || !total_cycles || !busy_cycles) {
+ rte_tel_data_free(lcore_ids);
+ rte_tel_data_free(total_cycles);
+ rte_tel_data_free(busy_cycles);
+ return -ENOMEM;
+ }
+
+ rte_tel_data_start_dict(d);
+ rte_tel_data_start_array(lcore_ids, RTE_TEL_UINT_VAL);
+ rte_tel_data_start_array(total_cycles, RTE_TEL_UINT_VAL);
+ rte_tel_data_start_array(busy_cycles, RTE_TEL_UINT_VAL);
+ rte_tel_data_add_dict_container(d, "lcore_ids", lcore_ids, 0);
+ rte_tel_data_add_dict_container(d, "total_cycles", total_cycles, 0);
+ rte_tel_data_add_dict_container(d, "busy_cycles", busy_cycles, 0);
+ usage.lcore_ids = lcore_ids;
+ usage.total_cycles = total_cycles;
+ usage.busy_cycles = busy_cycles;
+
+ return rte_lcore_iterate(lcore_telemetry_usage_cb, &usage);
+}
+
RTE_INIT(lcore_telemetry)
{
rte_telemetry_register_cmd(
@@ -577,5 +634,8 @@ RTE_INIT(lcore_telemetry)
rte_telemetry_register_cmd(
"/eal/lcore/info", handle_lcore_info,
"Returns lcore info. Parameters: int lcore_id");
+ rte_telemetry_register_cmd(
+ "/eal/lcore/usage", handle_lcore_usage,
+ "Returns lcore cycles usage. Takes no parameters");
}
#endif /* !RTE_EXEC_ENV_WINDOWS */
--
2.39.1