From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 24ABB41C34;
	Tue,  7 Feb 2023 22:39:23 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B40EE40A84;
	Tue,  7 Feb 2023 22:39:22 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 91D6940151
 for <dev@dpdk.org>; Tue,  7 Feb 2023 22:39:21 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id C2CCA20C7E37; Tue,  7 Feb 2023 13:39:20 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C2CCA20C7E37
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1675805960;
 bh=xC3VASBpyy0PAHTkUix69IPNSe3TKxBnIOXvFq/dins=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=kKmpi/ERUvXRxU4RhR50GdKBViiT/CSYw+4hR7Sj4AnANpFMXU7tYOqB9wOatTtAb
 qRsXS2Jh31t6Z8tQbArZ8mecRWfy7xB8rwv4+6+xt3ijsi1faM8w4iWyDYdkkbuHtC
 lXL63gZQGpjyYeA1CkXbZqDBKlPZGrhLHwPR76LA=
Date: Tue, 7 Feb 2023 13:39:20 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, olivier.matz@6wind.com,
 stephen@networkplumber.org, mb@smartsharesystems.com, hofors@lysator.liu.se
Subject: Re: [PATCH v5 2/3] doc: add missing index entry for thread
Message-ID: <20230207213920.GA30628@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1670271868-11364-1-git-send-email-roretzla@linux.microsoft.com>
 <1675197017-11287-1-git-send-email-roretzla@linux.microsoft.com>
 <1675197017-11287-3-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8yHmeg=hNyKHB=rZ29yRkCm8T5muX-fjGAnkuKhZQFvwA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8yHmeg=hNyKHB=rZ29yRkCm8T5muX-fjGAnkuKhZQFvwA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Feb 07, 2023 at 04:39:06PM +0100, David Marchand wrote:
> On Tue, Jan 31, 2023 at 9:30 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Add missing thread index referencing rte_thread.h under the basic
> > topic.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> >  doc/api/doxy-api-index.md | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> > index de488c7..e8ed51a 100644
> > --- a/doc/api/doxy-api-index.md
> > +++ b/doc/api/doxy-api-index.md
> > @@ -211,6 +211,7 @@ The public API headers are grouped by topics:
> >    [config file](@ref rte_cfgfile.h),
> >    [key/value args](@ref rte_kvargs.h),
> >    [string](@ref rte_string_fns.h)
> > +  [thread](@ref rte_thread.h)
> 
> A , is missing on the line before.
> This can be seen in the rendered html:
> "basic: bitops, approx fraction, random, config file, key/value args,
> string thread"

sorry, just me being a derp. i will fix it in the next version since
need a new rev for moving the test to test_threads.c

> 
> I'll fix when applying.
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> 
> -- 
> David Marchand