From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F9A041C44; Thu, 9 Feb 2023 01:04:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA66340DDA; Thu, 9 Feb 2023 01:04:25 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 565574067B for ; Thu, 9 Feb 2023 01:04:24 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id j1so589039pjd.0 for ; Wed, 08 Feb 2023 16:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vehJzRTMoVaKV+RhOwXRz2l/jESCyWwj8XR0Zsq0IJ0=; b=7XNgYqNfhDC36IUcwqKPUGU1mUYscJWMAuxXAabd09yHTBi7JntqNR3X32r4/+WmHZ wH5UA57nod7vpyVb97ktnyK0iO4/V4kJOj476jzdLEZ7MyW9wUTvNWyPMe7F8hKpMjh0 rO+m8vQq1dH3WpJFfEl3WQDYy56LQKbRuijS8GtupQnLgrlEMpXBypbtwPh7pgZonKQm nPycQwD9ickDKADrRj9MpuR6jbkQzCNFHlklKBJsBx60EoPT1UkVJZRzZmC2n/j6k/J3 MzHLuSoE/SuSOCnbHYPRnimIN1grbTSv0lySfqtXziFBdOo/BwQOATLu1nCoxlv73wYM X7xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vehJzRTMoVaKV+RhOwXRz2l/jESCyWwj8XR0Zsq0IJ0=; b=p5vm/roXyUTFVO21Jyr86iAF7g04Xc+couTkam2YTZA/UX0QYkjcyVBIjOzoedP4ef +uFllv1eFKhoJs6uJsbd7GflacqqCGjrHOSIxihv4mRfih4+0SnmS2rhoQAlmUYINbGo mXhzQgZAowDUaPdRNcLKAp7xD3OebQx08cUNA7jkc4hWxgoZLqr75j5fRQGSe7TiZmHD HC9MJpgUVXGVBQGhFuyNVesdzRFWnpLFd7J5ldsJk4FSIOzR2lm9+w1IU0oG/PJ/nXOH t9qFzX1C7p3zt8WDNBzuEvErcAfyeq4gT0AgzxlcfIvHLp6c7DzELclA3sWsBDw15r9j 2EhA== X-Gm-Message-State: AO0yUKV/9ANADALnH4nrOFrDzOrS812iMk4Kq95fcfnz+P0s/45SMb2W t7bggGKOVO6sK206m/Mh/VDNHA== X-Google-Smtp-Source: AK7set+wLbXMLIxvaY3A6+cKii4Cg3PHMGT4FUjnbwd/KxL5mhmAkg9f+U3J39hiY44QT/F8q0OICQ== X-Received: by 2002:a05:6a20:7d85:b0:b8:90fb:4f44 with SMTP id v5-20020a056a207d8500b000b890fb4f44mr11470173pzj.21.1675901063484; Wed, 08 Feb 2023 16:04:23 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id z186-20020a6265c3000000b005821c109cebsm11630733pfb.199.2023.02.08.16.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 16:04:23 -0800 (PST) Date: Wed, 8 Feb 2023 16:04:21 -0800 From: Stephen Hemminger To: Chengwen Feng Cc: , , , , , , , Subject: Re: [PATCH v13 1/6] memarea: introduce memarea library Message-ID: <20230208160421.05ba646c@hermes.local> In-Reply-To: <20230208082452.43883-2-fengchengwen@huawei.com> References: <20220721044648.6817-1-fengchengwen@huawei.com> <20230208082452.43883-1-fengchengwen@huawei.com> <20230208082452.43883-2-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 8 Feb 2023 08:24:47 +0000 Chengwen Feng wrote: > +RTE_LOG_REGISTER_DEFAULT(rte_memarea_logtype, INFO); > +#define RTE_MEMAREA_LOG(level, ...) \ > + rte_log(RTE_LOG_ ## level, rte_memarea_logtype, RTE_FMT("memarea: " \ > + RTE_FMT_HEAD(__VA_ARGS__,) "\n", RTE_FMT_TAIL(__VA_ARGS__,))) > + For me it is easier to read as: #define RTE_MEMAREA_LOG(level, fmt, args...) \ rte_log(RTE_LOG_ ## level, rte_memarea_logtype, \ "memarea: " fmt "\n", ## args) A common convention is to use "%s: " and __func__.