From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AC7A41C45; Thu, 9 Feb 2023 03:38:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 397314161A; Thu, 9 Feb 2023 03:38:08 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 42A6740DDA for ; Thu, 9 Feb 2023 03:38:06 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PC1Fy2ZjnzJsN1; Thu, 9 Feb 2023 10:36:22 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 9 Feb 2023 10:38:04 +0800 From: Chengwen Feng To: , , CC: , , , Subject: [PATCH v5 1/2] dmadev: support stats reset telemetry command Date: Thu, 9 Feb 2023 02:32:02 +0000 Message-ID: <20230209023203.35269-2-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230209023203.35269-1-fengchengwen@huawei.com> References: <20221219090723.29356-1-fengchengwen@huawei.com> <20230209023203.35269-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The stats reset is useful for debugging, so add it to the dmadev telemetry command lists. Signed-off-by: Chengwen Feng Reviewed-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c | 47 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c index 8c095e1f35..acd4cc9750 100644 --- a/lib/dmadev/rte_dmadev.c +++ b/lib/dmadev/rte_dmadev.c @@ -994,6 +994,51 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused, return 0; } +static int +dmadev_handle_dev_stats_reset(const char *cmd __rte_unused, + const char *params, + struct rte_tel_data *d) +{ + struct rte_dma_info dma_info; + int dev_id, ret, vchan_id; + const char *vchan_param; + char *end_param; + + if (params == NULL || strlen(params) == 0 || !isdigit(*params)) + return -EINVAL; + + dev_id = strtoul(params, &end_param, 0); + + /* Function info_get validates dev_id so we don't need to. */ + ret = rte_dma_info_get(dev_id, &dma_info); + if (ret < 0) + return -EINVAL; + + /* If the device has one vchan the user does not need to supply the + * vchan id and only the device id is needed, no extra parameters. + */ + if (dma_info.nb_vchans == 1 && *end_param == '\0') { + vchan_id = 0; + } else { + vchan_param = strtok(end_param, ","); + if (vchan_param == NULL || strlen(vchan_param) == 0 || !isdigit(*vchan_param)) + return -EINVAL; + vchan_id = strtoul(vchan_param, &end_param, 0); + } + if (*end_param != '\0') + RTE_DMA_LOG(WARNING, "Extra parameters passed to dmadev telemetry command, ignoring"); + + ret = rte_dma_stats_reset(dev_id, vchan_id); + if (ret == 0) { + rte_tel_data_string(d, "success"); + RTE_DMA_LOG(NOTICE, "Device %d reset stats success", dev_id); + } else { + RTE_DMA_LOG(ERR, "Device %d reset stats failed! ret: %d", dev_id, ret); + } + + return ret; +} + #ifndef RTE_EXEC_ENV_WINDOWS static int dmadev_handle_dev_dump(const char *cmd __rte_unused, @@ -1041,6 +1086,8 @@ RTE_INIT(dmadev_init_telemetry) "Returns information for a dmadev. Parameters: int dev_id"); rte_telemetry_register_cmd("/dmadev/stats", dmadev_handle_dev_stats, "Returns the stats for a dmadev vchannel. Parameters: int dev_id, vchan_id (Optional if only one vchannel)"); + rte_telemetry_register_cmd("/dmadev/stats_reset", dmadev_handle_dev_stats_reset, + "Reset the stats for a dmadev vchannel. Parameters: int dev_id, vchan_id (Optional if only one vchannel)"); #ifndef RTE_EXEC_ENV_WINDOWS rte_telemetry_register_cmd("/dmadev/dump", dmadev_handle_dev_dump, "Returns dump information for a dmadev. Parameters: int dev_id"); -- 2.17.1