From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBA9A41C53; Thu, 9 Feb 2023 17:48:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8EAD42B8C; Thu, 9 Feb 2023 17:48:32 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 93581410F9 for ; Thu, 9 Feb 2023 17:48:30 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id d13-20020a17090ad3cd00b0023127b2d602so2944758pjw.2 for ; Thu, 09 Feb 2023 08:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SIamZkvQXLRblsj/cCz716lYx5UMr1xmSepv9mRrIT0=; b=EMr4avEY5SOhnQZVFCV22PY/Zr2Z2ltxImN4SZ8EZ+t/hDiaeg1BSnA7YoE/b3pbHh ru6wO71MXvgalcE9qkbwFAHiijBx+wo4ettCYulR5W3SypKsP3Jd+HbM7gb0fzr/eogq YdepqkyRxW2ZKHVs8TemY0auQMWOQualSx+ivQ2GkJYfCFLsIsL5F5q60tYLNHqBxtVA eArDd3fyw8gBiUfceUpyjKTciyeWYvuBO4E2cv8jjO9nekcN/zKj8kLhmt8iK4ryYU5U 7rfgduLlXoCkMmO+xeBp+5obqpObS+XLZm/TdwVlnL5GvB0k+uqkhwWCLVJSbRV12PvX ABhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SIamZkvQXLRblsj/cCz716lYx5UMr1xmSepv9mRrIT0=; b=wnQle+BtqKXXNwccj22U1e7cxIjBE+gqZBP7BNURjnpDR6+/kYw3Hhn7PJndw8lykk UMveF+Aoa9sVlaXaokdwU6Enql5tsM9HT9uMZYVWVs+r6hmZJZWkL8kYzsjMLoVACfhw d9KbI7w3k7nVO2CGYOIoo3B44LTnbIVd1ydDI8Ck7EebJUO3Er87eJH6FwufDwaDqsz6 EZikCRKVNUTaT7Hc6iCfBnX1zXvhAZz4O82ViOTgXdKtcOngA+NiAL3p9Pj2lgbHeeke hIRorJkoF1VNxPKw/fw5SdSggTTnLRgcs601F6oNm7im/K8krPA0tqnvK2CUBRPBBkY+ Gzqw== X-Gm-Message-State: AO0yUKU2lnHwR7ZrzelmuN31xTSbvbErilI1UjNiKwbxp4gwYJ8NOTMw nqu+Z6bl8zgL6kZ3qZoCLkO9PA== X-Google-Smtp-Source: AK7set+o0B24cQylPcM2Oy9RHlNAJ5Iy4u2cI9cqAFKwLVndMkO5JaY3LCDZvKbBZIzp52z74IiKEw== X-Received: by 2002:a17:902:da83:b0:196:5839:b36a with SMTP id j3-20020a170902da8300b001965839b36amr13050951plx.8.1675961309699; Thu, 09 Feb 2023 08:48:29 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jo24-20020a170903055800b001899c2a0ae0sm1694880plb.40.2023.02.09.08.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 08:48:29 -0800 (PST) Date: Thu, 9 Feb 2023 08:48:27 -0800 From: Stephen Hemminger To: David Marchand Cc: Amit Prakash Shukla , Reshma Pattan , dev@dpdk.org, jerinj@marvell.com Subject: Re: [PATCH v5 1/3] pcapng: comment option support for epb Message-ID: <20230209084827.39388aa9@hermes.local> In-Reply-To: References: <20230124112139.1426279-1-amitprakashs@marvell.com> <20230203081925.2201007-1-amitprakashs@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 9 Feb 2023 10:13:41 +0100 David Marchand wrote: > Stephen, Reshma, > > On Fri, Feb 3, 2023 at 9:19 AM Amit Prakash Shukla > wrote: > > > > This change enhances rte_pcapng_copy to have comment in enhanced > > packet block. > > > > Signed-off-by: Amit Prakash Shukla > > Is this change ok for you? > Thanks. > Yes Acked-by: Stephen Hemminger