DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net,
	mb@smartsharesystems.com, Honnappa.Nagarahalli@arm.com
Subject: Re: [PATCH v2] eal: introduce atomics abstraction
Date: Thu, 9 Feb 2023 16:36:16 -0800	[thread overview]
Message-ID: <20230210003616.GA26239@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <0b711951-b982-d984-60f2-2a7be272dd69@amd.com>

On Thu, Feb 09, 2023 at 10:13:41PM +0000, Ferruh Yigit wrote:
> On 2/9/2023 5:40 PM, Tyler Retzlaff wrote:
> > On Thu, Feb 09, 2023 at 12:53:41PM +0000, Ferruh Yigit wrote:
> >> On 2/9/2023 9:04 AM, Bruce Richardson wrote:
> >>> On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote:
> >>>> Introduce atomics abstraction that permits optional use of standard C11
> >>>> atomics when meson is provided the new enable_stdatomics=true option.
> >>>>
> >>>> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> >>>> ---
> >>>>  config/meson.build                     | 11 ++++
> >>>>  lib/eal/arm/include/rte_atomic_32.h    |  6 ++-
> >>>>  lib/eal/arm/include/rte_atomic_64.h    |  6 ++-
> >>>>  lib/eal/include/generic/rte_atomic.h   | 96 +++++++++++++++++++++++++++++++++-
> >>>>  lib/eal/loongarch/include/rte_atomic.h |  6 ++-
> >>>>  lib/eal/ppc/include/rte_atomic.h       |  6 ++-
> >>>>  lib/eal/riscv/include/rte_atomic.h     |  6 ++-
> >>>>  lib/eal/x86/include/rte_atomic.h       |  8 ++-
> >>>>  meson_options.txt                      |  2 +
> >>>>  9 files changed, 139 insertions(+), 8 deletions(-)
> >>>>
> >>>> diff --git a/config/meson.build b/config/meson.build
> >>>> index 26f3168..25dd628 100644
> >>>> --- a/config/meson.build
> >>>> +++ b/config/meson.build
> >>>> @@ -255,6 +255,17 @@ endif
> >>>>  # add -include rte_config to cflags
> >>>>  add_project_arguments('-include', 'rte_config.h', language: 'c')
> >>>>  
> >>>> +stdc_atomics_enabled = get_option('enable_stdatomics')
> >>>> +dpdk_conf.set('RTE_STDC_ATOMICS', stdc_atomics_enabled)
> >>>> +
> >>>> +if stdc_atomics_enabled
> >>>> +if cc.get_id() == 'gcc' or cc.get_id() == 'clang'
> >>>> +    add_project_arguments('-std=gnu11', language: 'c')
> >>>
> >>> Is there a reason for using gnu11 on gcc and clang, rather than limiting
> >>> ourselves to proper c11 support?
> >>>
> >>
> >> +1 to stick to c11 standard instead of relying compiler extensions
> > 
> > the extensions are already in use. enabling -std=c11 causes warnings
> > about the extensions to start being emitted.
> > 
> 
> There is '__extension__' keyword (RTE_STD_C11) which is already used in
> many places, can it help to remove the warnings? If it helps we can use
> it, which helps to document where compiler extensions used in the code.

yeah, that macro name kind of makes no sense when you realize it expands
to __extension__ because a lot of places is it use isn't about an
extension for something from a standard header. sometimes it's used to
just annotate regular old gcc extensions/syntax.

i vaguely recall that the actual warning is for a missing declaration of
an extern function or something (presumably because it comes from glibc)
but not using -std=gnu11 or the macro dance didn't make the prototype
visible in the stdxxx.h header.

so i don't think __extension__ would actually be a good way to suppress
that warning and even if it did i'm trying to reduce code that carries
__extension__ to improve portability anyway.

i'll submit a new version of the patch series fixing it but without the
-std=gnu11 it's really the right thing to do.

ty

> 
> > but since i feel encouraged here, i think i will interpret your request
> > as let's limit the scope of enablement of extensions to where they are
> > already used instead of enabling them over the whole build.
> > 
> > i will submit a new revision patch to get rid of -std=gnu11 here.
> > 
> > thanks!

  reply	other threads:[~2023-02-10  0:36 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 21:26 [PATCH] eal: abstract compiler atomics Tyler Retzlaff
2023-01-12 21:26 ` [PATCH] eal: introduce atomics abstraction Tyler Retzlaff
2023-01-31 22:42   ` Thomas Monjalon
2023-02-01  1:07     ` Honnappa Nagarahalli
2023-02-01  8:09       ` Morten Brørup
2023-02-01 21:41       ` Tyler Retzlaff
2023-02-02  8:43         ` Morten Brørup
2023-02-02 19:00           ` Tyler Retzlaff
2023-02-02 20:44             ` Morten Brørup
2023-02-03 13:56               ` Bruce Richardson
2023-02-03 14:25                 ` Morten Brørup
2023-02-03 12:19             ` Bruce Richardson
2023-02-03 20:49               ` Tyler Retzlaff
2023-02-07 15:16                 ` Morten Brørup
2023-02-07 21:58                   ` Tyler Retzlaff
2023-02-07 23:34         ` Honnappa Nagarahalli
2023-02-08  1:20           ` Tyler Retzlaff
2023-02-08  8:31             ` Morten Brørup
2023-02-08 16:35               ` Tyler Retzlaff
2023-02-09  0:16                 ` Honnappa Nagarahalli
2023-02-09  8:34                   ` Morten Brørup
2023-02-09 17:30                   ` Tyler Retzlaff
2023-02-10  5:30                     ` Honnappa Nagarahalli
2023-02-10 20:30                       ` Tyler Retzlaff
2023-02-13  5:04                         ` Honnappa Nagarahalli
2023-02-13 15:28                           ` Ben Magistro
2023-02-13 15:55                             ` Bruce Richardson
2023-02-13 16:46                               ` Ben Magistro
2023-02-13 17:49                                 ` Morten Brørup
2023-02-13 23:18                           ` Tyler Retzlaff
2023-01-31 21:33 ` [PATCH] eal: abstract compiler atomics Tyler Retzlaff
2023-02-08 21:43 ` [PATCH v2] " Tyler Retzlaff
2023-02-08 21:43   ` [PATCH v2] eal: introduce atomics abstraction Tyler Retzlaff
2023-02-09  8:05     ` Morten Brørup
2023-02-09 18:15       ` Tyler Retzlaff
2023-02-09 19:19         ` Morten Brørup
2023-02-09 22:04           ` Tyler Retzlaff
2023-04-03 21:17       ` Mattias Rönnblom
2023-02-09  9:04     ` Bruce Richardson
2023-02-09 12:53       ` Ferruh Yigit
2023-02-09 17:40         ` Tyler Retzlaff
2023-02-09 22:13           ` Ferruh Yigit
2023-02-10  0:36             ` Tyler Retzlaff [this message]
2023-02-09 17:38       ` Tyler Retzlaff
2023-04-03 21:32         ` Mattias Rönnblom
2023-04-03 21:11     ` Mattias Rönnblom
2023-04-03 21:25       ` Honnappa Nagarahalli
2023-04-04  2:24       ` Tyler Retzlaff
2023-02-22 18:09   ` [PATCH v2] eal: abstract compiler atomics Tyler Retzlaff
2023-02-22 20:07     ` Honnappa Nagarahalli
2023-02-23 19:11       ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210003616.GA26239@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=mb@smartsharesystems.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).