From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DC1A941C5B;
Fri, 10 Feb 2023 07:54:39 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C9FD842B8E;
Fri, 10 Feb 2023 07:54:39 +0100 (CET)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by mails.dpdk.org (Postfix) with ESMTP id D424640EE3
for <dev@dpdk.org>; Fri, 10 Feb 2023 07:54:38 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAD96C14;
Thu, 9 Feb 2023 22:55:20 -0800 (PST)
Received: from ampere-altra-2-1.usa.Arm.com (ampere-altra-2-1.usa.arm.com
[10.118.91.158])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3E4D23F8C6;
Thu, 9 Feb 2023 22:54:38 -0800 (PST)
From: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
To: Yuying.Zhang@intel.com, beilei.xing@intel.com, olivier.matz@6wind.com,
andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com,
mb@smartsharesystems.com, konstantin.ananyev@huawei.com,
Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com, feifei.wang2@arm.com
Cc: dev@dpdk.org, nd@arm.com,
Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
Subject: [PATCH v2 1/2] net/i40e: replace put function
Date: Fri, 10 Feb 2023 06:54:06 +0000
Message-Id: <20230210065407.209567-2-kamalakshitha.aligeri@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230210065407.209567-1-kamalakshitha.aligeri@arm.com>
References: <20230209062501.142828-1-kamalakshitha.aligeri@arm.com>
<20230210065407.209567-1-kamalakshitha.aligeri@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Integrated zero-copy put API in mempool cache in i40e PMD.
On Ampere Altra server, l3fwd single core's performance improves by 5%
with the new API
Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
---
Link: https://patchwork.dpdk.org/project/dpdk/patch/20230209145833.129986-1-mb@smartsharesystems.com/
.mailmap | 1 +
drivers/net/i40e/i40e_rxtx_vec_common.h | 28 ++++++++++++++++++++-----
2 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/.mailmap b/.mailmap
index 75884b6fe2..05a42edbcf 100644
--- a/.mailmap
+++ b/.mailmap
@@ -670,6 +670,7 @@ Kai Ji <kai.ji@intel.com>
Kaiwen Deng <kaiwenx.deng@intel.com>
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Kamalakannan R <kamalakannan.r@intel.com>
+Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
Kamil Bednarczyk <kamil.bednarczyk@intel.com>
Kamil Chalupnik <kamilx.chalupnik@intel.com>
Kamil Rytarowski <kamil.rytarowski@caviumnetworks.com>
diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
index fe1a6ec75e..113599d82b 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -95,18 +95,36 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
n = txq->tx_rs_thresh;
- /* first buffer to free from S/W ring is at index
- * tx_next_dd - (tx_rs_thresh-1)
- */
+ /* first buffer to free from S/W ring is at index
+ * tx_next_dd - (tx_rs_thresh-1)
+ */
txep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];
if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
+ struct rte_mempool *mp = txep[0].mbuf->pool;
+ struct rte_mempool_cache *cache = rte_mempool_default_cache(mp, rte_lcore_id());
+ void **cache_objs;
+
+ if (unlikely(!cache))
+ goto fallback;
+
+ cache_objs = rte_mempool_cache_zc_put_bulk(cache, mp, n);
+ if (unlikely(!cache_objs))
+ goto fallback;
+
for (i = 0; i < n; i++) {
- free[i] = txep[i].mbuf;
+ cache_objs[i] = txep->mbuf;
/* no need to reset txep[i].mbuf in vector path */
+ txep++;
}
- rte_mempool_put_bulk(free[0]->pool, (void **)free, n);
goto done;
+
+fallback:
+ for (i = 0; i < n; i++)
+ free[i] = txep[i].mbuf;
+ rte_mempool_generic_put(mp, (void **)free, n, cache);
+ goto done;
+
}
m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
--
2.25.1