From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A44041C4F; Fri, 10 Feb 2023 17:35:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EA31410EA; Fri, 10 Feb 2023 17:35:01 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 82DEC410D3 for ; Fri, 10 Feb 2023 17:35:00 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id o8so4650492pls.11 for ; Fri, 10 Feb 2023 08:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=E1B1sikKx94bBwCLJtkA+H2ebQtjjp6hEWSSr4yT578=; b=Y+9tP+Jrflupdb9QnIi0tlGztK/OOwnOXJ/CvMimajXX1SV5rL/Xt/i3bFtusL5QmL IyETd2qFGYS34ZHTZ1vuoqYdQGG0Wuhs0bPuKmDHrTybQTbe0AQOEq54yFtZA0ZWZ5Gy JQGQo0tXPE1LIxNn+ZIpvur7kp+FpPtLTyMFG4UQt6fnuOkLzfUxx70g5RCFLngr0Url eW6rSLgzrF9UP7pwF9vorZeBbGOeDjjmMN9PKe39BcGVRvcxCNubesEymY90GPirYEvD uOzGYzRW4h213t8bFF2Yx+NLiaMxr7QVa/OeKFz8RuVStlvNLSQuzPmtCd3NWz96FXls vjQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E1B1sikKx94bBwCLJtkA+H2ebQtjjp6hEWSSr4yT578=; b=wwSWl9DCKIknprw7bNZQKv08zVdqu69JAyv/FETNBg9z3B40jTZClAVF+gtvpmeTbk 5LkgU9isWkBMSDe0EEAnY52jRug+kWkOJFzRYv3FnWUTD8wYz3Gg1p3L3mL0wjhqMFk3 t+TcZYYx9+d4OlsP7tmsB1TnvNn/0k7JcCwZc7UTAj1ubqm7meBwpZ5v7Df+oZKk2EpZ exymhS6ST7OYAELUVj/qW7/G01GC7muXBRAJZm2rwHLfRNf0fWidHdTzaZMkDbHwAts/ 0fiYo6v9JaBAFAo9709ZDDPyhWIwLP6+Zelf3hzBczuagagixCiG1Prj7AdexnIf6C0l Fpzg== X-Gm-Message-State: AO0yUKWHnsYPMw5JYqG8w+TkaPCTe6Xye3u19LFb0Ijn4MWhtRpm0CFN cdXhT3t7/rV253c4IdwS9VYcTVJ4Vl37UH/eia8= X-Google-Smtp-Source: AK7set/sHQs0EKe+Mv10FzRby2vAOfJ6Eu2362sRX0VQT98an5cTjsSPQ3QfQ68OQ9xuBnT59/+IDQ== X-Received: by 2002:a17:903:24f:b0:198:a08a:e52b with SMTP id j15-20020a170903024f00b00198a08ae52bmr18685377plh.13.1676046899407; Fri, 10 Feb 2023 08:34:59 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id v12-20020a1709029a0c00b0019339f3368asm3642544plp.3.2023.02.10.08.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 08:34:59 -0800 (PST) Date: Fri, 10 Feb 2023 08:34:57 -0800 From: Stephen Hemminger To: Levend Sayar Cc: junfeng.guo@intel.com, dev@dpdk.org Subject: Re: [PATCH 2/2] net/gve: add standard and extended statistics Message-ID: <20230210083457.0e20a310@hermes.local> In-Reply-To: <20230210130606.57036-1-levendsayar@gmail.com> References: <20230210130606.57036-1-levendsayar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 10 Feb 2023 16:06:06 +0300 Levend Sayar wrote: > +gve_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + uint16_t i; > + struct rte_eth_stats tmp; > + > + memset(&tmp, 0, sizeof(tmp)) Why do you need tmp? The stats pointer passed in is already available and zeroed.