From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F109441C61; Fri, 10 Feb 2023 21:14:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4A82410D3; Fri, 10 Feb 2023 21:14:50 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 665D740687 for ; Fri, 10 Feb 2023 21:14:49 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id u9so7613233plr.9 for ; Fri, 10 Feb 2023 12:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rESYFxBhhPTl7WfnjcdUsg+S+X+F1V8fwsp0esgaQaQ=; b=RoD3OUGVbQ240dFbMjRR8/I+nTX/cSZIjio8nv+aLaKb50EeBOR8r/+hMKr5Eo++sF XMJooOGoDQipt8CZbQb78+PPK8o+DP8t2+flxniriwEHISHugUj3mU3Va1X1A6NiLCZX grSio8rbAS5uItGZXkHk0HPxKTBGua8RYfmChamQW4ms+SradG265rgxnHoEY46rxF3P ra0MJeZ73v7P326DtCC4xbOdWmMujtsJmZ+3epQ/Cx9rgjv0j4i7fqjRulxMq5eJbap4 7msINhCnOf9Mwap//o2ZnFdhz+QlRYCO1jqiSMPBkdDFfJc+Cc77AutJiDl2UsjQDmbB xhzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rESYFxBhhPTl7WfnjcdUsg+S+X+F1V8fwsp0esgaQaQ=; b=xmNjpQRsQkhYNhh1nbtZ1NFtV5lpcaulnEOGvJ2vYyKTQOVMLU7fU5xWfxI8iVPhcE dhhdUBKZBfjF6LCNUiqgyVtS9gE9xnCNOsM3zuDrh++/6B3m36edcj82c7909fN2ytl1 majCiYd03eKW4gD34xtcB/mZs1X8M3Ww7FHJ9DgUjaGrTxq3uXOoLR4yi9aOxf4d6Gwv BBUHZobbm4rs0uXrpy8ky6xlrdW68Zq53JKElC/VwhsbeXTW6rxrNLStjJ2Ky6/j8Nqa RBsswVhU20rOB2rq8iSx4dAQ82ctLoTqm5WYu6R/n9Fpl+CjnVMOftMMg8fpB0ha9X/t w9xw== X-Gm-Message-State: AO0yUKX/vQ1GKMVXpqtNLVGEu/R7JLM2SLGEMoNbfF5RsM2aiY9j/9tL MDB7iKRwAk9Xf6deNdNw43U/fQ== X-Google-Smtp-Source: AK7set/r8mxSNRIz6ZvS+Wp36eYuDNyqOqGWfMZPaYBW1Qg3/g4eXznD0FF+DqiHjTYapepkEcUNpQ== X-Received: by 2002:a05:6a20:8e05:b0:c3:18f8:6c3a with SMTP id y5-20020a056a208e0500b000c318f86c3amr14162742pzj.9.1676060088402; Fri, 10 Feb 2023 12:14:48 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id m4-20020a637d44000000b00478eb777d18sm3355394pgn.72.2023.02.10.12.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 12:14:48 -0800 (PST) Date: Fri, 10 Feb 2023 12:14:45 -0800 From: Stephen Hemminger To: Levend Sayar Cc: Junfeng Guo , dev@dpdk.org Subject: Re: [PATCH 2/2] net/gve: add standard and extended statistics Message-ID: <20230210121445.51b04e2b@hermes.local> In-Reply-To: <20DC6215-2930-43A4-8C9A-8B8B90D8F43F@gmail.com> References: <20230210130606.57036-1-levendsayar@gmail.com> <20230210083457.0e20a310@hermes.local> <20DC6215-2930-43A4-8C9A-8B8B90D8F43F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 10 Feb 2023 20:25:41 +0300 Levend Sayar wrote: > Accessing a stack variable is faster. > So copying to given stats pointer will be done at once. > But of course, given stats pointer can also be used. I doubt there is an observable difference. Access to a stack variable is offset from register. Access to the stats (parameter) is offset from a different register. The area reserved for stats will already be in cache since it was just zero'd by the caller.