From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2319241CA8; Wed, 15 Feb 2023 18:18:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 124A040A7D; Wed, 15 Feb 2023 18:18:02 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id C68E74067E for ; Wed, 15 Feb 2023 18:18:00 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id k24so132795pji.2 for ; Wed, 15 Feb 2023 09:18:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BU2lVW6XA2dQzw1K8QWfW9X+0o+tDDtkSPhLhJ9FPko=; b=OCEajEQD/RvckFiuvZQ9UoibESGqIG15zISyfpb6GAzNcXkEP2YJyGvPEiUPRJxqmh 5gdn9JzhW5hfnC6bdb3PwV3Fdjosq1RoyU1TZrmHsureSbKlPyekvg2VkLExTDkotTCT S7fPtNn+wcXs4nsYfs0YGW4+J8i3CNOlmOmUbvmBRitzC6roBDtF2bR6YlUpNbVwOzfO k+mDGrWunV8Fn+A84C5qX16+eJbtY9Skphj5CdsmtDhNys2bxzgobjkJU7pEUSFUrSsC 133b5zQye++oqJNKdTkFgS3KNtUHQtAAKZSkrMCMJhCaxeoAQSbKAMBOAfnFlEUaYeq0 vnEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BU2lVW6XA2dQzw1K8QWfW9X+0o+tDDtkSPhLhJ9FPko=; b=PsS0kGLaGVoAWKt9OEMzTp+VaP2WHILf8na6hlWwbHTSFKAhtyGwJGNCFJvEpP5fWx o9Aa1fK55nL/SYtSYMXaWXHc88VxdjjccA0JDN/l9GR/dzXC2Fm6UkxD9iCpFIDUzdlD 2XYPWp6/fTy6ENCxTlnD1f7+bpsue7m7lBlcWWXX5wrzC6oNn2xZUur24hKyuCB5u3Gf xLyQpQCPoeu9IeqiPZSRiFRqrJCXumkUnDO2YAAz+O40JdjPG7k40hfcNn2O2OhDzp+v 5xCrvqppoKNiV20zZJjmDIBGxvltdgf61+R4RTt7d4ZUMuKLRmetwyhMEuozwuQpSMr5 2rOg== X-Gm-Message-State: AO0yUKW6N49q7v4Y0qcslRDyx49lS8RXcSQ4Z0ntwgMnMGdEcKaGjpsz FJMpLLqBkuyse0mIYkVsCXr3NQ== X-Google-Smtp-Source: AK7set/rv/H/i3ThBylN03xbpCjKf49F2dZeYsMgQw8bydtXot2ovNdJgt9qpQ2iUfVBeMdHGrQuAg== X-Received: by 2002:a05:6a20:9051:b0:be:dd3a:6da5 with SMTP id e17-20020a056a20905100b000bedd3a6da5mr1890840pzc.23.1676481479927; Wed, 15 Feb 2023 09:17:59 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j21-20020aa78d15000000b00581c741f95csm11899029pfe.46.2023.02.15.09.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 09:17:59 -0800 (PST) Date: Wed, 15 Feb 2023 09:17:59 -0800 From: Stephen Hemminger To: Hemant Agrawal Cc: dev@dpdk.org, thomas@monjalon.net Subject: Re: [PATCH 2/2] drivers: replace printf with fprintf for debug functions Message-ID: <20230215091759.348e659a@hermes.local> In-Reply-To: <20230215102905.22767-2-hemant.agrawal@nxp.com> References: <20230215102905.22767-1-hemant.agrawal@nxp.com> <20230215102905.22767-2-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 15 Feb 2023 15:59:05 +0530 Hemant Agrawal wrote: > diff --git a/drivers/bus/dpaa/base/fman/netcfg_layer.c b/drivers/bus/dpaa/base/fman/netcfg_layer.c > index 6a405c984d..69cee08fb9 100644 > --- a/drivers/bus/dpaa/base/fman/netcfg_layer.c > +++ b/drivers/bus/dpaa/base/fman/netcfg_layer.c > @@ -33,33 +33,33 @@ dump_netcfg(struct netcfg_info *cfg_ptr) > { > int i; > > - printf(".......... DPAA Configuration ..........\n\n"); > + fprintf(stdout, ".......... DPAA Configuration ..........\n\n"); > If you only do "printf -> fprintf(stdout," then it doesn't make sense. Ideally change debug interface to take a user supplied output FILE * like other dump routines.