DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ankur Dwivedi <adwivedi@marvell.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>,
	<ferruh.yigit@amd.com>, <jerinj@marvell.com>,
	Ankur Dwivedi <adwivedi@marvell.com>
Subject: [PATCH v3 1/5] mempool: remove internal tracepoints from version map
Date: Wed, 15 Feb 2023 15:12:24 +0530	[thread overview]
Message-ID: <20230215094228.1452656-2-adwivedi@marvell.com> (raw)
In-Reply-To: <20230215094228.1452656-1-adwivedi@marvell.com>

The file rte_mempool_trace.h contains tracepoints which are internal to the
mempool library. This file is renamed to mempool_trace.h, and is made an
internal header. The tracepoints in this file are removed from the
experimental section in version.map file.

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 .../{rte_mempool_trace.h => mempool_trace.h}       |  6 +++---
 lib/mempool/mempool_trace_points.c                 |  2 +-
 lib/mempool/meson.build                            |  1 -
 lib/mempool/rte_mempool.c                          |  2 +-
 lib/mempool/rte_mempool_ops.c                      |  2 +-
 lib/mempool/version.map                            | 14 --------------
 6 files changed, 6 insertions(+), 21 deletions(-)
 rename lib/mempool/{rte_mempool_trace.h => mempool_trace.h} (98%)

diff --git a/lib/mempool/rte_mempool_trace.h b/lib/mempool/mempool_trace.h
similarity index 98%
rename from lib/mempool/rte_mempool_trace.h
rename to lib/mempool/mempool_trace.h
index 087c913c8c..3e663c72e4 100644
--- a/lib/mempool/rte_mempool_trace.h
+++ b/lib/mempool/mempool_trace.h
@@ -2,8 +2,8 @@
  * Copyright(C) 2020 Marvell International Ltd.
  */
 
-#ifndef _RTE_MEMPOOL_TRACE_H_
-#define _RTE_MEMPOOL_TRACE_H_
+#ifndef _MEMPOOL_TRACE_H_
+#define _MEMPOOL_TRACE_H_
 
 /**
  * @file
@@ -172,4 +172,4 @@ RTE_TRACE_POINT(
 }
 #endif
 
-#endif /* _RTE_MEMPOOL_TRACE_H_ */
+#endif /* _MEMPOOL_TRACE_H_ */
diff --git a/lib/mempool/mempool_trace_points.c b/lib/mempool/mempool_trace_points.c
index 4ad76deb34..307018094d 100644
--- a/lib/mempool/mempool_trace_points.c
+++ b/lib/mempool/mempool_trace_points.c
@@ -4,7 +4,7 @@
 
 #include <rte_trace_point_register.h>
 
-#include "rte_mempool_trace.h"
+#include "mempool_trace.h"
 
 RTE_TRACE_POINT_REGISTER(rte_mempool_trace_ops_dequeue_bulk,
 	lib.mempool.ops.deq.bulk)
diff --git a/lib/mempool/meson.build b/lib/mempool/meson.build
index b8aaa00694..8099a56466 100644
--- a/lib/mempool/meson.build
+++ b/lib/mempool/meson.build
@@ -17,7 +17,6 @@ sources = files(
 )
 headers = files(
         'rte_mempool.h',
-        'rte_mempool_trace.h',
         'rte_mempool_trace_fp.h',
 )
 deps += ['ring', 'telemetry']
diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
index 45b5df6199..cf5dea2304 100644
--- a/lib/mempool/rte_mempool.c
+++ b/lib/mempool/rte_mempool.c
@@ -28,8 +28,8 @@
 #include <rte_eal_paging.h>
 #include <rte_telemetry.h>
 
+#include "mempool_trace.h"
 #include "rte_mempool.h"
-#include "rte_mempool_trace.h"
 
 TAILQ_HEAD(rte_mempool_list, rte_tailq_entry);
 
diff --git a/lib/mempool/rte_mempool_ops.c b/lib/mempool/rte_mempool_ops.c
index 3b43edc548..ae1d288f27 100644
--- a/lib/mempool/rte_mempool_ops.c
+++ b/lib/mempool/rte_mempool_ops.c
@@ -11,7 +11,7 @@
 #include <rte_errno.h>
 #include <dev_driver.h>
 
-#include "rte_mempool_trace.h"
+#include "mempool_trace.h"
 
 /* indirect jump table to support external memory pools. */
 struct rte_mempool_ops_table rte_mempool_ops_table = {
diff --git a/lib/mempool/version.map b/lib/mempool/version.map
index b67d7aace7..dff2d1cb55 100644
--- a/lib/mempool/version.map
+++ b/lib/mempool/version.map
@@ -47,22 +47,8 @@ EXPERIMENTAL {
 	__rte_mempool_trace_generic_get;
 	__rte_mempool_trace_get_bulk;
 	__rte_mempool_trace_get_contig_blocks;
-	__rte_mempool_trace_create;
-	__rte_mempool_trace_create_empty;
-	__rte_mempool_trace_free;
-	__rte_mempool_trace_populate_iova;
-	__rte_mempool_trace_populate_virt;
-	__rte_mempool_trace_populate_default;
-	__rte_mempool_trace_populate_anon;
-	__rte_mempool_trace_cache_create;
-	__rte_mempool_trace_cache_free;
 	__rte_mempool_trace_default_cache;
-	__rte_mempool_trace_get_page_size;
 	__rte_mempool_trace_cache_flush;
-	__rte_mempool_trace_ops_populate;
-	__rte_mempool_trace_ops_alloc;
-	__rte_mempool_trace_ops_free;
-	__rte_mempool_trace_set_ops_byname;
 };
 
 INTERNAL {
-- 
2.25.1


  reply	other threads:[~2023-02-15  9:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 13:30 [PATCH v1 0/5] " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 1/5] mempool: " Ankur Dwivedi
2023-02-09 14:23   ` David Marchand
2023-02-10  5:32     ` [EXT] " Ankur Dwivedi
2023-02-10  5:44   ` Jerin Jacob
2023-02-10  7:00     ` [EXT] " Ankur Dwivedi
2023-02-10  7:06       ` Jerin Jacob
2023-02-10 14:24         ` David Marchand
2023-02-10 15:32           ` Jerin Jacob
2023-02-14 11:37             ` Ankur Dwivedi
2023-02-20 14:18               ` David Marchand
2023-02-09 13:30 ` [PATCH v1 2/5] cryptodev: " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 3/5] eal: " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 4/5] ethdev: " Ankur Dwivedi
2023-02-09 14:13   ` Ferruh Yigit
2023-02-09 13:30 ` [PATCH v1 5/5] eventdev: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 0/5] " Ankur Dwivedi
2023-02-10 10:34   ` [PATCH v2 1/5] mempool: " Ankur Dwivedi
2023-02-10 10:34   ` [PATCH v2 2/5] cryptodev: " Ankur Dwivedi
2023-02-10 10:34   ` [PATCH v2 3/5] eal: " Ankur Dwivedi
2023-02-10 10:34   ` [PATCH v2 4/5] ethdev: " Ankur Dwivedi
2023-02-10 14:19     ` David Marchand
2023-02-13  8:14       ` [EXT] " Ankur Dwivedi
2023-02-10 10:34   ` [PATCH v2 5/5] eventdev: " Ankur Dwivedi
2023-02-10 13:08     ` Jerin Jacob
2023-02-15  9:42   ` [PATCH v3 0/5] " Ankur Dwivedi
2023-02-15  9:42     ` Ankur Dwivedi [this message]
2023-02-15  9:42     ` [PATCH v3 2/5] cryptodev: " Ankur Dwivedi
2023-02-15  9:42     ` [PATCH v3 3/5] eal: " Ankur Dwivedi
2023-02-15  9:42     ` [PATCH v3 4/5] ethdev: " Ankur Dwivedi
2023-02-15  9:42     ` [PATCH v3 5/5] eventdev: " Ankur Dwivedi
2023-02-20 14:39     ` [PATCH v3 0/5] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215094228.1452656-2-adwivedi@marvell.com \
    --to=adwivedi@marvell.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).