[PATCH] net/nfp: remove the unneeded check logic

[PATCH] net/nfp: remove the unneeded check logic

[Chaoyong He]

Remove the unneeded check logic of ingress and egress flow attribute.
After the OVS commit c7da49bc ("netdev-offload-dpdk: Fix transfer flows"),
the flow can not offload anymore if we don't do this modification.

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 drivers/net/nfp/nfp_flow.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c
index bd3a8d2a3b..c9abaa3adc 100644
--- a/drivers/net/nfp/nfp_flow.c
+++ b/drivers/net/nfp/nfp_flow.c
@@ -3613,7 +3613,7 @@ nfp_flow_setup(struct nfp_flower_representor *representor,
 		const struct rte_flow_attr *attr,
 		const struct rte_flow_item items[],
 		const struct rte_flow_action actions[],
-		struct rte_flow_error *error,
+		__rte_unused struct rte_flow_error *error,
 		bool validate_flag)
 {
 	if (attr->group != 0)
@@ -3625,18 +3625,6 @@ nfp_flow_setup(struct nfp_flower_representor *representor,
 	if (attr->transfer != 0)
 		PMD_DRV_LOG(INFO, "Pretend we support transfer attribute.");
 
-	if (attr->egress != 0) {
-		rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
-				NULL, "Egress is not supported.");
-		return NULL;
-	}
-
-	if (attr->ingress == 0) {
-		rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
-				NULL, "Only ingress is supported.");
-		return NULL;
-	}
-
 	return nfp_flow_process(representor, items, actions, validate_flag);
 }
 
-- 
2.29.3

Re: [PATCH] net/nfp: remove the unneeded check logic

[Ferruh Yigit]

On 2/16/2023 6:28 AM, Chaoyong He wrote:
> Remove the unneeded check logic of ingress and egress flow attribute.
> After the OVS commit c7da49bc ("netdev-offload-dpdk: Fix transfer flows"),
> the flow can not offload anymore if we don't do this modification.
> 
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

Applied to dpdk-next-net/main, thanks.