From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7045C41CE2;
Sun, 19 Feb 2023 18:51:17 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 71CF842D74;
Sun, 19 Feb 2023 18:51:04 +0100 (CET)
Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com
[209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 3A28C42D44
for <dev@dpdk.org>; Sun, 19 Feb 2023 18:51:03 +0100 (CET)
Received: by mail-pj1-f51.google.com with SMTP id
f8-20020a17090ac28800b00233d7314c1cso1003505pjt.5
for <dev@dpdk.org>; Sun, 19 Feb 2023 09:51:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:from:to:cc:subject:date:message-id
:reply-to; bh=+OX+5Gc9Ufx/dVQ5IQSFLZlMz+IBoMZY763RrbJFXZo=;
b=iw8+/FYWTnfc8tJOah+YUMGwlgxgeR6MmcCL92h3IvDjjjNTMMtA0YIt6j4+LGI63k
tAKO51tIzWqI53fI/45xy8QkXWj8mCpUNdiXd3rccVCpXHtOQO9QiLVdLJDwZKln6gPh
wsURSnUSFPhB4iKihfF47MYdhkCxSnjtAGX30YWcu6yKFBFJTwDoUwb8TJoJVZv2n3Hd
yVr59rincZLDm9x6B+K3miWnV/k+wMpnjbMIVPweTkRSVmFwFLvKLXyAA8KjIPnlhMuI
hGQTAKusJIufjCbLUiG2aAWPozB+bDSJTcFsOt6GIFemLdd2kt+Q41WyL2d3S6alzxbt
Pgig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=+OX+5Gc9Ufx/dVQ5IQSFLZlMz+IBoMZY763RrbJFXZo=;
b=ai3eOAnyINH91TQHyxcwFGzDJeMYJk70UFZ6HoUKhncKj7Z9AWT12GE/IyEOWr3scZ
bNtju/umDpppdz8QQ+pOehfLgXxvjG9HPQsSNE4Sju08VENdDkjuIn5ySqGdKcuwbxyl
nuf61il7Fi9Bje/dQtQYXxFGdi1sHuVzgHKGACm3vD9hOikXbGB9viGcN0I/458KcoM4
M9qKgQQgAmaq2MGWsPOQnXdA2TzFPr79GpvQ/U/dw/0HyNGxMewrqYrJe4s4MGwSxvxY
ee2zgl3O5OJhBl+zgHuWxD5myj6SsxV0gEID/ZDMO0T5HZZ8DjGqjey5EEuF8jQhBf0R
iZTQ==
X-Gm-Message-State: AO0yUKXuvCMAnLOrSdMInMRxIG3MOQi8VDHV6jZ7zSeySlKHeEDdyly5
CmlKjjjHFiWntncrSgC3mGyxu0iLC+V5aVuSRvw=
X-Google-Smtp-Source: AK7set9Jly64gJQZuo7xsYaq5q+GV7iRllWLJJz/KPLNbqAHp5l6GSKA1xBaks+FuWNMeBcI8anlCQ==
X-Received: by 2002:a17:902:e84b:b0:19a:84db:76ed with SMTP id
t11-20020a170902e84b00b0019a84db76edmr747401plg.15.1676829062130;
Sun, 19 Feb 2023 09:51:02 -0800 (PST)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
by smtp.gmail.com with ESMTPSA id
jj13-20020a170903048d00b0019927ca0f8fsm6257175plb.62.2023.02.19.09.51.01
for <dev@dpdk.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 19 Feb 2023 09:51:01 -0800 (PST)
Date: Sun, 19 Feb 2023 09:50:59 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [PATCH] app/dumpcap: don't pass negative value to strerror() on
error
Message-ID: <20230219095059.3e9722b2@hermes.local>
In-Reply-To: <20230207170050.1093917-1-stephen@networkplumber.org>
References: <20230207170050.1093917-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Tue, 7 Feb 2023 09:00:50 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:
> If eth_stats_get fails (for example with -ENOTSUPP) then
> dumpcap would pass that to strerror which is incorrect.
>
> Fixes: 8744f84bb255 ("app/dumpcap: add statistics mode")
> Coverity issue: 383136
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Small bug fix, please apply