From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D32EE41CE4; Sun, 19 Feb 2023 23:59:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B03C042D5E; Sun, 19 Feb 2023 23:59:06 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id C762740698 for ; Sun, 19 Feb 2023 23:59:04 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 83so744174pgf.6 for ; Sun, 19 Feb 2023 14:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=x5nfARgmP+SK4eM72I2zPbZPkH4LPNq7SmniUJBL6ig=; b=hjKuVU12hMZ/dvWijSpOjSZ0L38on2fkENbXzrgS5aDMYE8cpXoRm194ddhwbEk5qv YZw1lKNq07EkbiFsiwWAtLhPn0l/B0SgMjq+WAEkvyeSqD7Effpt4F7fLKTF5KaRiuqx mGWK65ZW4S6eF28PWfjtGzUEEMmei1lfhVqvm6wnFuAn9TWVkkXAyhAXn9ASEVcuznSK qZBWa3+kOXqi6sbe43eCWtHlaiaLqzmIwxo/09qJKeRJ+mseGC3baREDfhtUphXPxLct witzm/qnggcN2wNxZg57oJkpiPk289+ro8yWMtGAP8J7Pb8021a3ZPwI4A1q0jD/aNkM zTOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x5nfARgmP+SK4eM72I2zPbZPkH4LPNq7SmniUJBL6ig=; b=YqlO1eScri6oLVemGNSiI79P0z3UyiU0CMVHOx78SWy0K0j/pb8Bne1bk+rIJoxr7K yKrOw/VLC13DRHBFcNwzu1DfBT231AUccH+Aju6gMYNyqjAtHeQNk5D9YeFGts6+iz+Q fyG9mVA4l22yaG/B3N+U29mo18ICNsVpFQG7fuW3PD7EYQXwOaxzJnE/vZL4S0joe6Wh DmJMCTFvCC785IaT/kOQf9N6R1SYoRQBySJRPBrw7bIjwPcFAOYrW5faZTmqMc9HdH4t 0lYFEM/q8N3ubxsBfNwSGxHNlEdIvmit7CKlfCSp/voNONwlkgwVnQPcgepJhE0HzdyL XOLw== X-Gm-Message-State: AO0yUKVSTNwMZGiYDeRs7wdoO6V9gUzmZXXDmUBPOS4Q4wX6tPyf7DWE HDpQtNGJiham7UfzqpARajj2wg== X-Google-Smtp-Source: AK7set+8j5sRxGAi1njhHlvltoVfTcwpmknoObeQxlfKn/rqSAbkeQvNOfbInmhOAoI09XUWLqXfxA== X-Received: by 2002:a62:1881:0:b0:5aa:2216:5c5c with SMTP id 123-20020a621881000000b005aa22165c5cmr1853668pfy.33.1676847543629; Sun, 19 Feb 2023 14:59:03 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id b13-20020aa7810d000000b00581d62be96dsm6325829pfi.197.2023.02.19.14.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 14:59:03 -0800 (PST) Date: Sun, 19 Feb 2023 14:59:01 -0800 From: Stephen Hemminger To: Levend Sayar Cc: junfeng.guo@intel.com, dev@dpdk.org Subject: Re: [PATCH] net/gve: fix Rx no mbufs stats counter update Message-ID: <20230219145901.0638b22b@hermes.local> In-Reply-To: <9B306604-8CC8-4CC6-B58F-9A5B28C3D3CB@gmail.com> References: <20230219003059.85479-1-levendsayar@gmail.com> <20230219093543.45ed457e@hermes.local> <9B306604-8CC8-4CC6-B58F-9A5B28C3D3CB@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 19 Feb 2023 23:43:08 +0300 Levend Sayar wrote: > LS: =E2=80=9Cunlikely=E2=80=9D can be added. You=E2=80=99re right. Code a= lready tries to make a bulk allocation first. > If that bulk allocation does not work, it tries to allocate one my one. That seems like a unnecessary step and unlikely to help. Unless the user abuses driver by giving a very small mbuf pool.