DPDK patches and discussions
 help / color / mirror / Atom feed
From: Krzysztof Karas <krzysztof.karas@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Kai Ji <kai.ji@intel.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, Krzysztof Karas <krzysztof.karas@intel.com>
Subject: [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()
Date: Mon, 20 Feb 2023 18:13:18 +0100	[thread overview]
Message-ID: <20230220171318.1836477-1-krzysztof.karas@intel.com> (raw)

Commit b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request
handler") is part of DPDK 22.11 release and it enforces usage of shared
config and multiprocess mode.

DPDK is not required to be run with more than one
process in general, so instead of erroring out,
catch the error and proceed with ipsec_mb device
creation normally.

Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 .mailmap                                   | 1 +
 drivers/crypto/ipsec_mb/ipsec_mb_private.c | 9 ++-------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/.mailmap b/.mailmap
index a9f4f28fba..dad475b9d0 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1583,3 +1583,4 @@ Ziye Yang <ziye.yang@intel.com>
 Zoltan Kiss <zoltan.kiss@schaman.hu> <zoltan.kiss@linaro.org>
 Zorik Machulsky <zorik@amazon.com>
 Zyta Szpak <zyta@marvell.com> <zr@semihalf.com> <zyta.szpak@semihalf.com>
+Krzysztof Karas <krzysztof.karas@intel.com>
diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
index 50b789a29b..9eebf9bbc9 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
@@ -170,13 +170,8 @@ ipsec_mb_create(struct rte_vdev_device *vdev,
 
 	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
 		retval = ipsec_mb_mp_request_register();
-		if (retval && (rte_errno == EEXIST))
-			/* Safe to proceed, return 0 */
-			return 0;
-
-		if (retval)
-			IPSEC_MB_LOG(ERR,
-				"IPSec Multi-buffer register MP request failed.\n");
+		if (retval != 0 && rte_errno == ENOTSUP)
+			retval = 0;
 	}
 	return retval;
 }
-- 
2.34.1

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.


             reply	other threads:[~2023-02-20 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 17:13 Krzysztof Karas [this message]
2023-02-27 18:26 ` [EXT] " Akhil Goyal
2023-02-28 23:24   ` Ji, Kai
2023-03-13 12:01 ` [PATCH v2] crypto/ipsec_mb: expect ENOTSUP Krzysztof Karas
2023-03-14 17:25   ` Ji, Kai
2023-03-16 18:46     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230220171318.1836477-1-krzysztof.karas@intel.com \
    --to=krzysztof.karas@intel.com \
    --cc=dev@dpdk.org \
    --cc=kai.ji@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).