From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D37E741CEE; Mon, 20 Feb 2023 19:35:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B43C3430C1; Mon, 20 Feb 2023 19:35:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3E52D40395 for <dev@dpdk.org>; Mon, 20 Feb 2023 19:35:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676918112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4/NaddUQkQcJKMJ7l6AZWLMgqiOPbYaup95/FgQ0U5A=; b=Cx2iTOuc10Oj46qoSiuirDjToLBvtAfusvDLohopMJ4iK5WU5qgSKDNhSWPhTbiGvdiC5J jsjmSCcOtZ4KV7skEMFZFQ0xBLZv1LOIIIQneXWKTCxXqvwpR6v6OqM8N0lIm3HrdlQluc LWxvtQfdXiOgQ0HcjOUo2QDUzbqs8LM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-64-jReXDuPoMleTONFV4nruHw-1; Mon, 20 Feb 2023 13:35:09 -0500 X-MC-Unique: jReXDuPoMleTONFV4nruHw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F2BC802C18; Mon, 20 Feb 2023 18:35:08 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AF5FC15BA0; Mon, 20 Feb 2023 18:35:07 +0000 (UTC) From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: Ferruh Yigit <ferruh.yigit@amd.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Robin Jarry <rjarry@redhat.com> Subject: [PATCH v3 0/9] Testpmd code cleanup Date: Mon, 20 Feb 2023 19:34:53 +0100 Message-Id: <20230220183502.3348368-1-david.marchand@redhat.com> In-Reply-To: <20230124104742.1265439-1-david.marchand@redhat.com> References: <20230124104742.1265439-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Here is a series to reduce code duplication in testpmd. This work started from looking at Robin series on reporting lcore busy cycles in telemetry, which is then added in testpmd [1]. While looking at the forward engines code, I saw way too much duplicated code. Warning: this is only compile tested. 1: https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/ -- David Marchand --- Changes since v2: - fixed fwd_streams[] access in patch 6, Changes since v1: - rebased now that Robin series was merged, - reordered patches (putting fixes first in the series), - fixed more issues in separate patches for ieee1588 and noisy VNF fwd engines, - removed unneeded helpers for cycles counting, --- David Marchand (9): app/testpmd: fix Tx preparation in checksum engine app/testpmd: fix packet count in ieee15888 engine app/testpmd: rework ieee1588 engine fwd configuration app/testpmd: fix packet transmission in noisy VNF engine app/testpmd: bulk free mbufs app/testpmd: factorize core cycles record app/testpmd: factorize fwd engine init app/testpmd: factorize fwd engine Rx app/testpmd: factorize fwd engine Tx app/test-pmd/5tswap.c | 54 +++---------------- app/test-pmd/csumonly.c | 61 ++++------------------ app/test-pmd/flowgen.c | 53 +++---------------- app/test-pmd/icmpecho.c | 60 +++------------------- app/test-pmd/ieee1588fwd.c | 39 ++++++-------- app/test-pmd/iofwd.c | 54 +++---------------- app/test-pmd/macfwd.c | 53 +++---------------- app/test-pmd/macswap.c | 58 +++------------------ app/test-pmd/noisy_vnf.c | 97 ++++++----------------------------- app/test-pmd/rxonly.c | 20 ++------ app/test-pmd/shared_rxq_fwd.c | 18 +++---- app/test-pmd/testpmd.c | 30 ++++++++--- app/test-pmd/testpmd.h | 53 ++++++++++++------- app/test-pmd/txonly.c | 31 ++--------- 14 files changed, 153 insertions(+), 528 deletions(-) -- 2.39.2