DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
	Chaoyong He <chaoyong.he@corigine.com>,
	stable@dpdk.org
Subject: [PATCH 3/6] net/nfp: fix the set IPv6 flow action
Date: Tue, 21 Feb 2023 14:49:27 +0800	[thread overview]
Message-ID: <20230221064930.3399-4-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com>

The former logic of set IPv6 source/destination address flow action don't
consider the mask filed of control message passed to the firmware.
This caused the firmware skip the set action logic, and the offloaded
packets don't have the right IPv6 address as expected.

Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action")
Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action")
Cc: stable@dpdk.org

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 drivers/net/nfp/nfp_flow.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c
index 39493ce98d..a4561b08e8 100644
--- a/drivers/net/nfp/nfp_flow.c
+++ b/drivers/net/nfp/nfp_flow.c
@@ -2163,8 +2163,10 @@ nfp_flow_action_set_ipv6(char *act_data,
 	set_ip->head.len_lw = act_size >> NFP_FL_LW_SIZ;
 	set_ip->reserved = 0;
 
-	for (i = 0; i < 4; i++)
-		set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i];
+	for (i = 0; i < 4; i++) {
+		set_ip->ipv6[i].exact = *(const rte_be32_t *)&set_ipv6->ipv6_addr[i * 4];
+		set_ip->ipv6[i].mask = RTE_BE32(0xffffffff);
+	}
 }
 
 static void
-- 
2.29.3


  parent reply	other threads:[~2023-02-21  6:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21  6:49 [PATCH 0/6] fix the set flow actions Chaoyong He
2023-02-21  6:49 ` [PATCH 1/6] net/nfp: fix the set MAC flow action Chaoyong He
2023-02-21  6:49 ` [PATCH 2/6] net/nfp: fix the set IPv4 " Chaoyong He
2023-02-21  6:49 ` Chaoyong He [this message]
2023-02-21  6:49 ` [PATCH 4/6] net/nfp: fix the set TP " Chaoyong He
2023-02-21  6:49 ` [PATCH 5/6] net/nfp: fix the set TTL " Chaoyong He
2023-02-21  6:49 ` [PATCH 6/6] net/nfp: fix the set IPv4/v6 DSCP " Chaoyong He
2023-02-21 10:35 ` [PATCH v2 0/6] fix the set flow actions Chaoyong He
2023-02-21 10:35   ` [PATCH v2 1/6] net/nfp: fix the set MAC flow action Chaoyong He
2023-02-21 10:35   ` [PATCH v2 2/6] net/nfp: fix the set IPv4 " Chaoyong He
2023-02-21 10:35   ` [PATCH v2 3/6] net/nfp: fix the set IPv6 " Chaoyong He
2023-02-21 10:35   ` [PATCH v2 4/6] net/nfp: fix the set TP " Chaoyong He
2023-02-21 10:35   ` [PATCH v2 5/6] net/nfp: fix the set TTL " Chaoyong He
2023-02-21 10:35   ` [PATCH v2 6/6] net/nfp: fix the set IPv4/v6 DSCP " Chaoyong He
2023-03-03 14:26   ` [PATCH v2 0/6] fix the set flow actions Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221064930.3399-4-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).