From: Huisong Li <lihuisong@huawei.com>
To: <dev@dpdk.org>
Cc: <bruce.richardson@intel.com>, <mb@smartsharesystems.com>,
<hkalra@marvell.com>, <huangdaode@huawei.com>,
<fengchengwen@huawei.com>, <lihuisong@huawei.com>
Subject: [PATCH v2] mem: fix displaying heap ID failed for heap info command
Date: Wed, 22 Feb 2023 15:49:53 +0800 [thread overview]
Message-ID: <20230222074953.22715-1-lihuisong@huawei.com> (raw)
In-Reply-To: <20230209030341.9697-1-lihuisong@huawei.com>
The telemetry lib has added a allowed characters set for dictionary names.
Please see commit 2537fb0c5f34 ("telemetry: limit characters allowed in
dictionary names")
The space is not in this set, which cause the heap ID in /eal/heap_info
cannot be displayed. Additionally, 'heap' is also misspelling. So use
'Heap_id' to replace 'Head id'.
Fixes: e6732d0d6e26 ("mem: add telemetry infos")
Fixes: 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
-v2: add announcement in rel_notes.
---
doc/guides/rel_notes/release_23_03.rst | 2 ++
lib/eal/common/eal_common_memory.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst
index 49c18617a5..bdee535046 100644
--- a/doc/guides/rel_notes/release_23_03.rst
+++ b/doc/guides/rel_notes/release_23_03.rst
@@ -237,6 +237,8 @@ API Changes
* The experimental structures ``struct rte_graph_param``, ``struct rte_graph``
and ``struct graph`` were updated to support pcap trace in the graph library.
+* The ``Head ip`` in the displaying of ``/eal/heap_info`` telemetry command
+ is modified to ``Heap_id`` to ensure that it can be printed.
ABI Changes
-----------
diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c
index c917b981bc..c2a4c8f9e7 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -1139,7 +1139,7 @@ handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params,
malloc_heap_get_stats(heap, &sock_stats);
rte_tel_data_start_dict(d);
- rte_tel_data_add_dict_uint(d, "Head id", heap_id);
+ rte_tel_data_add_dict_uint(d, "Heap_id", heap_id);
rte_tel_data_add_dict_string(d, "Name", heap->name);
rte_tel_data_add_dict_uint(d, "Heap_size",
sock_stats.heap_totalsz_bytes);
--
2.33.0
next prev parent reply other threads:[~2023-02-22 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 3:03 [PATCH] " Huisong Li
2023-02-09 3:23 ` fengchengwen
2023-02-09 8:48 ` David Marchand
2023-02-11 2:58 ` lihuisong (C)
2023-02-11 3:04 ` lihuisong (C)
2023-02-22 7:49 ` Huisong Li [this message]
2023-02-22 7:53 ` [PATCH v2] " Morten Brørup
2023-03-12 8:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222074953.22715-1-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=hkalra@marvell.com \
--cc=huangdaode@huawei.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).