From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F016041D39; Wed, 22 Feb 2023 08:50:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D221C40697; Wed, 22 Feb 2023 08:50:49 +0100 (CET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 12A7840693 for ; Wed, 22 Feb 2023 08:50:47 +0100 (CET) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PM7W51CRCzKmT6; Wed, 22 Feb 2023 15:45:53 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 22 Feb 2023 15:50:43 +0800 From: Huisong Li To: CC: , , , , , Subject: [PATCH v2] mem: fix displaying heap ID failed for heap info command Date: Wed, 22 Feb 2023 15:49:53 +0800 Message-ID: <20230222074953.22715-1-lihuisong@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20230209030341.9697-1-lihuisong@huawei.com> References: <20230209030341.9697-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The telemetry lib has added a allowed characters set for dictionary names. Please see commit 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names") The space is not in this set, which cause the heap ID in /eal/heap_info cannot be displayed. Additionally, 'heap' is also misspelling. So use 'Heap_id' to replace 'Head id'. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Fixes: 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names") Cc: stable@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- -v2: add announcement in rel_notes. --- doc/guides/rel_notes/release_23_03.rst | 2 ++ lib/eal/common/eal_common_memory.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst index 49c18617a5..bdee535046 100644 --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst @@ -237,6 +237,8 @@ API Changes * The experimental structures ``struct rte_graph_param``, ``struct rte_graph`` and ``struct graph`` were updated to support pcap trace in the graph library. +* The ``Head ip`` in the displaying of ``/eal/heap_info`` telemetry command + is modified to ``Heap_id`` to ensure that it can be printed. ABI Changes ----------- diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c index c917b981bc..c2a4c8f9e7 100644 --- a/lib/eal/common/eal_common_memory.c +++ b/lib/eal/common/eal_common_memory.c @@ -1139,7 +1139,7 @@ handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params, malloc_heap_get_stats(heap, &sock_stats); rte_tel_data_start_dict(d); - rte_tel_data_add_dict_uint(d, "Head id", heap_id); + rte_tel_data_add_dict_uint(d, "Heap_id", heap_id); rte_tel_data_add_dict_string(d, "Name", heap->name); rte_tel_data_add_dict_uint(d, "Heap_size", sock_stats.heap_totalsz_bytes); -- 2.33.0