From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71FBD41D52; Thu, 23 Feb 2023 16:29:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 499304304B; Thu, 23 Feb 2023 16:29:01 +0100 (CET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mails.dpdk.org (Postfix) with ESMTP id C726242D65 for ; Thu, 23 Feb 2023 16:28:52 +0100 (CET) Received: by mail-ed1-f53.google.com with SMTP id d30so2235757eda.4 for ; Thu, 23 Feb 2023 07:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon-tech.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f0DT2TcxLQmRocxSFXZcWJCAdu9+N2gg4K+Sovehhno=; b=RPvQSHVNbekowXz8GNDCw+isjPq9Ob//KRS6zpgm4Y87F7+eazjY9swfEbP2fyGeD2 eft3gea15jbl0ahk3E2uq8DjHR/bxMeHbTuaGdA8VO1Ai0St9m/9L9DMX2mO4G18HOBm nKDoWITmIZWsEELzzLqRRbzqgcDHiDHWa/VH7FWaU9Tr4DAslh3xsbquAkaS51e/+b1i ScTNYmn6Od7SjMfZrpBpenkHXVgkpE0wYL7BaRL3TY8m5fqZ9Bojdi89L+evfdzqpamF FLUfpr/OkDeOHgxqfkppfxlIbMIBFYnsMecFZ7Pjo6jHAIog3flIWt7nIshP8k4Bo9jh ptJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f0DT2TcxLQmRocxSFXZcWJCAdu9+N2gg4K+Sovehhno=; b=cwNrGtvAE/HdYUCO+whpXaMXiK1J4aLt0XHx7XAIzXYK47al395hO0dUKe2Ssnm4Ro JbVynQD4JKuSkExAndaAeZWjbKA8WbD4WD7BHagt7f+Cv+X1iAlADTrHXsgJdNI52NJp cB4GEcSYy4VbeUAxH2SmztGOel5uZQsUdjov5l6K6zcSWOz9xGw0EpaXpGWA3Vm+AvJs TFfRkaeR8+VU632AgYJ9YxQ7KQ/NHyI7v3YXvlE3vTYHdhwwOnKStBjUw4GYFwaK0kmN P6db0lwlWrlhwCK36bBscXY9ehORmv910aI0QQvg9CXcq/w0t/1iuI7l61uCICCzQw7b jpbA== X-Gm-Message-State: AO0yUKXFRQv+MLq4dxBYfPejfuKWMfvFBWkLSvJFgmFvivhbjNwImZH7 vngjvlS859zIoaBqUmlV9uCERA== X-Google-Smtp-Source: AK7set/Gd1s7hyBIc9Xkc+NT/OXMoiCpwLS+80kHBAHaSjzDeRwEiMVdj/7fZZT1K6rVzR5r2XkecA== X-Received: by 2002:aa7:d412:0:b0:4ae:eae1:946a with SMTP id z18-20020aa7d412000000b004aeeae1946amr14710603edq.13.1677166132546; Thu, 23 Feb 2023 07:28:52 -0800 (PST) Received: from localhost.localdomain ([84.245.121.112]) by smtp.gmail.com with ESMTPSA id r6-20020a50c006000000b004af6a8617ffsm1158892edb.46.2023.02.23.07.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 07:28:52 -0800 (PST) From: =?UTF-8?q?Juraj=20Linke=C5=A1?= To: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, probb@iol.unh.edu Cc: dev@dpdk.org, =?UTF-8?q?Juraj=20Linke=C5=A1?= Subject: [PATCH v5 07/10] dts: add hello world testsuite Date: Thu, 23 Feb 2023 16:28:37 +0100 Message-Id: <20230223152840.634183-8-juraj.linkes@pantheon.tech> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230223152840.634183-1-juraj.linkes@pantheon.tech> References: <20230213152846.284191-1-juraj.linkes@pantheon.tech> <20230223152840.634183-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The test suite implements test cases defined in the corresponding test plan. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 2 +- dts/framework/remote_session/os_session.py | 16 ++++- .../remote_session/remote/__init__.py | 2 +- dts/framework/testbed_model/__init__.py | 1 + dts/framework/testbed_model/sut_node.py | 12 +++- dts/tests/TestSuite_hello_world.py | 64 +++++++++++++++++++ 6 files changed, 93 insertions(+), 4 deletions(-) create mode 100644 dts/tests/TestSuite_hello_world.py diff --git a/dts/framework/remote_session/__init__.py b/dts/framework/remote_session/__init__.py index 747316c78a..ee221503df 100644 --- a/dts/framework/remote_session/__init__.py +++ b/dts/framework/remote_session/__init__.py @@ -17,7 +17,7 @@ from .linux_session import LinuxSession from .os_session import OSSession -from .remote import RemoteSession, SSHSession +from .remote import CommandResult, RemoteSession, SSHSession def create_session( diff --git a/dts/framework/remote_session/os_session.py b/dts/framework/remote_session/os_session.py index 4753c70e91..2731a7ca0a 100644 --- a/dts/framework/remote_session/os_session.py +++ b/dts/framework/remote_session/os_session.py @@ -12,7 +12,7 @@ from framework.testbed_model import LogicalCore, MesonArgs from framework.utils import EnvVarsDict -from .remote import RemoteSession, create_remote_session +from .remote import CommandResult, RemoteSession, create_remote_session class OSSession(ABC): @@ -50,6 +50,20 @@ def is_alive(self) -> bool: """ return self.remote_session.is_alive() + def send_command( + self, + command: str, + timeout: float, + verify: bool = False, + env: EnvVarsDict | None = None, + ) -> CommandResult: + """ + An all-purpose API in case the command to be executed is already + OS-agnostic, such as when the path to the executed command has been + constructed beforehand. + """ + return self.remote_session.send_command(command, timeout, verify, env) + @abstractmethod def guess_dpdk_remote_dir(self, remote_dir) -> PurePath: """ diff --git a/dts/framework/remote_session/remote/__init__.py b/dts/framework/remote_session/remote/__init__.py index f3092f8bbe..8a1512210a 100644 --- a/dts/framework/remote_session/remote/__init__.py +++ b/dts/framework/remote_session/remote/__init__.py @@ -6,7 +6,7 @@ from framework.config import NodeConfiguration from framework.logger import DTSLOG -from .remote_session import RemoteSession +from .remote_session import CommandResult, RemoteSession from .ssh_session import SSHSession diff --git a/dts/framework/testbed_model/__init__.py b/dts/framework/testbed_model/__init__.py index 22c7c16708..485fc57703 100644 --- a/dts/framework/testbed_model/__init__.py +++ b/dts/framework/testbed_model/__init__.py @@ -13,6 +13,7 @@ from .hw import ( LogicalCore, LogicalCoreCount, + LogicalCoreCountFilter, LogicalCoreList, LogicalCoreListFilter, VirtualDevice, diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py index a9ae2e4a6f..12b4c5573b 100644 --- a/dts/framework/testbed_model/sut_node.py +++ b/dts/framework/testbed_model/sut_node.py @@ -8,7 +8,7 @@ from pathlib import PurePath from framework.config import BuildTargetConfiguration, NodeConfiguration -from framework.remote_session import OSSession +from framework.remote_session import CommandResult, OSSession from framework.settings import SETTINGS from framework.utils import EnvVarsDict, skip_setup @@ -248,3 +248,13 @@ def create_eal_parameters( vdevs=vdevs, other_eal_param=other_eal_param, ) + + def run_dpdk_app( + self, app_path: PurePath, eal_args: EalParameters, timeout: float = 30 + ) -> CommandResult: + """ + Run DPDK application on the remote node. + """ + return self.main_session.send_command( + f"{app_path} {eal_args}", timeout, verify=True + ) diff --git a/dts/tests/TestSuite_hello_world.py b/dts/tests/TestSuite_hello_world.py new file mode 100644 index 0000000000..7e3d95c0cf --- /dev/null +++ b/dts/tests/TestSuite_hello_world.py @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2010-2014 Intel Corporation + +""" +Run the helloworld example app and verify it prints a message for each used core. +No other EAL parameters apart from cores are used. +""" + +from framework.test_suite import TestSuite +from framework.testbed_model import ( + LogicalCoreCount, + LogicalCoreCountFilter, + LogicalCoreList, +) + + +class TestHelloWorld(TestSuite): + def set_up_suite(self) -> None: + """ + Setup: + Build the app we're about to test - helloworld. + """ + self.app_helloworld_path = self.sut_node.build_dpdk_app("helloworld") + + def test_hello_world_single_core(self) -> None: + """ + Steps: + Run the helloworld app on the first usable logical core. + Verify: + The app prints a message from the used core: + "hello from core " + """ + + # get the first usable core + lcore_amount = LogicalCoreCount(1, 1, 1) + lcores = LogicalCoreCountFilter(self.sut_node.lcores, lcore_amount).filter() + eal_para = self.sut_node.create_eal_parameters( + lcore_filter_specifier=lcore_amount + ) + result = self.sut_node.run_dpdk_app(self.app_helloworld_path, eal_para) + self.verify( + f"hello from core {int(lcores[0])}" in result.stdout, + f"helloworld didn't start on lcore{lcores[0]}", + ) + + def test_hello_world_all_cores(self) -> None: + """ + Steps: + Run the helloworld app on all usable logical cores. + Verify: + The app prints a message from all used cores: + "hello from core " + """ + + # get the maximum logical core number + eal_para = self.sut_node.create_eal_parameters( + lcore_filter_specifier=LogicalCoreList(self.sut_node.lcores) + ) + result = self.sut_node.run_dpdk_app(self.app_helloworld_path, eal_para, 50) + for lcore in self.sut_node.lcores: + self.verify( + f"hello from core {int(lcore)}" in result.stdout, + f"helloworld didn't start on lcore{lcore}", + ) -- 2.30.2