From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>
Subject: [PATCH] dma/idxd: add verbose option to config script
Date: Tue, 28 Feb 2023 14:50:36 +0000 [thread overview]
Message-ID: <20230228145035.11828-1-bruce.richardson@intel.com> (raw)
In case there are issues when configuring a device instance using the
dpdk_idxd_cfg.py script, add a "verbose" mode option to it. This allows
the user to see what changes are being made, and therefore which
operation, if any, within the config fails.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/dma/idxd/dpdk_idxd_cfg.py | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/dma/idxd/dpdk_idxd_cfg.py b/drivers/dma/idxd/dpdk_idxd_cfg.py
index 41b4d13b9c..c0c833ade9 100755
--- a/drivers/dma/idxd/dpdk_idxd_cfg.py
+++ b/drivers/dma/idxd/dpdk_idxd_cfg.py
@@ -13,18 +13,24 @@
class SysfsDir:
+ verbose = False
+
"Used to read/write paths in a sysfs directory"
def __init__(self, path):
self.path = path
def read_int(self, filename):
"Return a value from sysfs file"
+ if SysfsDir.verbose:
+ print(f"Reading '{filename}' in {self.path}")
with open(os.path.join(self.path, filename)) as f:
return int(f.readline())
def write_values(self, values):
"write dictionary, where key is filename and value is value to write"
for filename, contents in values.items():
+ if SysfsDir.verbose:
+ print(f"Writing '{contents}' to '{filename}' in {self.path}")
with open(os.path.join(self.path, filename), "w") as f:
f.write(str(contents))
@@ -124,12 +130,16 @@ def main(args):
help="Prefix for workqueue name to mark for DPDK use [default: 'dpdk']")
arg_p.add_argument('--wq-option', action='append', default=[],
help="Provide additional config option for queues (format 'x=y')")
+ arg_p.add_argument('--verbose', '-v', action='store_true',
+ help="Provide addition info on tasks being performed")
arg_p.add_argument('--reset', action='store_true',
help="Reset DSA device and its queues")
parsed_args = arg_p.parse_args(args[1:])
dsa_id = parsed_args.dsa_id
dsa_id = get_dsa_id(dsa_id) if ':' in dsa_id else dsa_id
+
+ SysfsDir.verbose = parsed_args.verbose
if parsed_args.reset:
reset_device(dsa_id)
else:
--
2.37.2
next reply other threads:[~2023-02-28 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 14:50 Bruce Richardson [this message]
2023-03-10 17:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228145035.11828-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).