From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CC02D41DB0;
Thu, 2 Mar 2023 03:21:59 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3BAF942D51;
Thu, 2 Mar 2023 03:20:55 +0100 (CET)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by mails.dpdk.org (Postfix) with ESMTP id 557C442D2F
for <dev@dpdk.org>; Thu, 2 Mar 2023 03:20:53 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1677723653; x=1709259653;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=ASZwA9IRmOKxm6dYgWsdZ4xM2nUS1xpdrJ2rzNbJGB0=;
b=Cl+XE1KCmSGrN8jmZEHiBDYfjdyDuE4V1/Lfqs4vJ4PS1/ZqHmWlBAlo
4uJLlavsj9wcGd7DFoEELL6jWAdJ/91qhHX7oThky2Y2L4r9IMPlX+L76
fpUaL4PeAj25PjMiveclvXaGhfyTp+wuCktxyEmnT8ONr+jDuI/63+T5w
AmCiwXO0HRqwpyLdja/58pkWzd3wdv/nhUNGR8nhkYP61+jf7cOpJuYIJ
cffMSOUsdQIV+12aFEKEvgYU/Q6Nz7dNN8Aa3hLMEifpB9HOfDSwq0+HJ
bM20w1G9VMHUaV61WaTawFZoLEdQrlc2GI2D7SFUyDgKh1mxjulEYXiv9 A==;
X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="315013569"
X-IronPort-AV: E=Sophos;i="5.98,226,1673942400"; d="scan'208";a="315013569"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Mar 2023 18:20:52 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="784607534"
X-IronPort-AV: E=Sophos;i="5.98,226,1673942400"; d="scan'208";a="784607534"
Received: from dpdk-mingxial-ice.sh.intel.com ([10.67.110.191])
by fmsmga002.fm.intel.com with ESMTP; 01 Mar 2023 18:20:51 -0800
From: Mingxia Liu <mingxia.liu@intel.com>
To: dev@dpdk.org,
beilei.xing@intel.com,
yuying.zhang@intel.com
Cc: Mingxia Liu <mingxia.liu@intel.com>
Subject: [PATCH v8 11/21] net/cpfl: support write back based on ITR expire
Date: Thu, 2 Mar 2023 10:35:17 +0000
Message-Id: <20230302103527.931071-12-mingxia.liu@intel.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230302103527.931071-1-mingxia.liu@intel.com>
References: <20230216003010.3439881-1-mingxia.liu@intel.com>
<20230302103527.931071-1-mingxia.liu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
ITR is the interval between two interrupts, it can be understood
as a timer here. WB_ON_ITR(write back on ITR expire) is used for
receiving packets without interrupts or full cache line, then
packets can be received one by one.
To enable WB_ON_ITR, need to enable some interrupt with
'idpf_vport_irq_map_config()' first.
Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
drivers/net/cpfl/cpfl_ethdev.c | 45 +++++++++++++++++++++++++++++++++-
drivers/net/cpfl/cpfl_ethdev.h | 2 ++
2 files changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index 37e0270dd7..b09c7d4996 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -209,6 +209,15 @@ cpfl_dev_configure(struct rte_eth_dev *dev)
return 0;
}
+static int
+cpfl_config_rx_queues_irqs(struct rte_eth_dev *dev)
+{
+ struct idpf_vport *vport = dev->data->dev_private;
+ uint16_t nb_rx_queues = dev->data->nb_rx_queues;
+
+ return idpf_vport_irq_map_config(vport, nb_rx_queues);
+}
+
static int
cpfl_start_queues(struct rte_eth_dev *dev)
{
@@ -246,12 +255,37 @@ static int
cpfl_dev_start(struct rte_eth_dev *dev)
{
struct idpf_vport *vport = dev->data->dev_private;
+ struct idpf_adapter *base = vport->adapter;
+ struct cpfl_adapter_ext *adapter = CPFL_ADAPTER_TO_EXT(base);
+ uint16_t num_allocated_vectors = base->caps.num_allocated_vectors;
+ uint16_t req_vecs_num;
int ret;
+ req_vecs_num = CPFL_DFLT_Q_VEC_NUM;
+ if (req_vecs_num + adapter->used_vecs_num > num_allocated_vectors) {
+ PMD_DRV_LOG(ERR, "The accumulated request vectors' number should be less than %d",
+ num_allocated_vectors);
+ ret = -EINVAL;
+ goto err_vec;
+ }
+
+ ret = idpf_vc_vectors_alloc(vport, req_vecs_num);
+ if (ret != 0) {
+ PMD_DRV_LOG(ERR, "Failed to allocate interrupt vectors");
+ goto err_vec;
+ }
+ adapter->used_vecs_num += req_vecs_num;
+
+ ret = cpfl_config_rx_queues_irqs(dev);
+ if (ret != 0) {
+ PMD_DRV_LOG(ERR, "Failed to configure irqs");
+ goto err_irq;
+ }
+
ret = cpfl_start_queues(dev);
if (ret != 0) {
PMD_DRV_LOG(ERR, "Failed to start queues");
- return ret;
+ goto err_startq;
}
cpfl_set_rx_function(dev);
@@ -269,6 +303,11 @@ cpfl_dev_start(struct rte_eth_dev *dev)
err_vport:
cpfl_stop_queues(dev);
+err_startq:
+ idpf_vport_irq_unmap_config(vport, dev->data->nb_rx_queues);
+err_irq:
+ idpf_vc_vectors_dealloc(vport);
+err_vec:
return ret;
}
@@ -284,6 +323,10 @@ cpfl_dev_stop(struct rte_eth_dev *dev)
cpfl_stop_queues(dev);
+ idpf_vport_irq_unmap_config(vport, dev->data->nb_rx_queues);
+
+ idpf_vc_vectors_dealloc(vport);
+
vport->stopped = 1;
return 0;
diff --git a/drivers/net/cpfl/cpfl_ethdev.h b/drivers/net/cpfl/cpfl_ethdev.h
index 9738e89ca8..4d1441ae64 100644
--- a/drivers/net/cpfl/cpfl_ethdev.h
+++ b/drivers/net/cpfl/cpfl_ethdev.h
@@ -25,6 +25,8 @@
#define CPFL_INVALID_VPORT_IDX 0xffff
+#define CPFL_DFLT_Q_VEC_NUM 1
+
#define CPFL_MIN_BUF_SIZE 1024
#define CPFL_MAX_FRAME_SIZE 9728
#define CPFL_DEFAULT_MTU RTE_ETHER_MTU
--
2.34.1