From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 38BD241DB6;
	Thu,  2 Mar 2023 18:19:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2CD3740E09;
	Thu,  2 Mar 2023 18:19:09 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 54D84400D6
 for <dev@dpdk.org>; Thu,  2 Mar 2023 18:19:08 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id A291B20B9C3D; Thu,  2 Mar 2023 09:19:07 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A291B20B9C3D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1677777547;
 bh=tS7MiROMMLs7wB0QMtIqNFDaoqCqqkX6WxB9w2guB94=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=W33+6cwCMoo73wjmeKWK2bWaMAkUb7/6vglPu0tC1HJJdnrgK3FSudDd4zdWPeNMZ
 V5M8QuoMlRzWv85zraSL8n/G+zBPt1sdJpTqkwnRdJnr1hTeWQiCFX2mMOAlPDsIag
 5zaYqr+xi+EoBPfkqVKO4s+JQ/DO7e+CVkeI4VXk=
Date: Thu, 2 Mar 2023 09:19:07 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Tal Shnaiderman <talshn@nvidia.com>,
 Matan Azrad <matan@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH v3 2/3] net/mlx5: remove weak stub functions
Message-ID: <20230302171907.GC29061@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230105161020.247780-1-thomas@monjalon.net>
 <20230302132150.3330288-1-thomas@monjalon.net>
 <20230302132150.3330288-3-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230302132150.3330288-3-thomas@monjalon.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Mar 02, 2023 at 02:21:49PM +0100, Thomas Monjalon wrote:
> The vector Rx functions are conditionally compiled.
> Some stub functions were also always compiled with weak attribute.
> If there is no vector support, the weak functions were linked.
> 
> These weak functions are moved in a specific file
> which is compiled only if there is no vector support.
> This way it is simpler to understand,
> and the weak attributes can be removed.
> 
> This change helps to compile with MinGW GCC
> which has no support for weak functions.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>