From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D199C41D73; Thu, 2 Mar 2023 12:37:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C568040E2D; Thu, 2 Mar 2023 12:37:02 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8F8C240E09 for ; Thu, 2 Mar 2023 12:37:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677757021; x=1709293021; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dARTaJXLRRuOhmeVXDYIa/nHx4um7zg5Gag3p53+wJY=; b=XUHk9z6Hcrcxg+ndWY+3NYfs4ImSS4g3WX70BgDUbNgidkFGTdB0Hci/ eyk4jlNEfc2CoDfIDr0Nj9mIquz1idUd5iC67g5UTMrvPa/1L07JEv9V0 9F+0UK1sbdAyL+LQJJVERTPH1Gki2ybMr7P3v8h0uPz+Ud+9oMy/VPWOX DKn/joZjnSwq0N49wnPiCvvCcafQ83hc/fGXOXw5lQxE/q5Cco8mcHFl2 I2CD9oYatmMClH6ZxV1jon07+nOh5tBwOz0zmoKyaEJrR6zX97ZDdjr0q nU4E5q9cssS3Mc4/JBmNNCfThhNUayvSnKh6LeQ7MOwWed0es02UzLoxM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="399485072" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="399485072" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 03:36:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="1004077607" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="1004077607" Received: from dpdk-mingxial-ice.sh.intel.com ([10.67.110.191]) by fmsmga005.fm.intel.com with ESMTP; 02 Mar 2023 03:36:14 -0800 From: Mingxia Liu To: dev@dpdk.org Cc: jingjing.wu@intel.com, beilei.xing@intel.com, Mingxia Liu Subject: [PATCH v3] net/idpf: refine Rx/Tx queue model info Date: Thu, 2 Mar 2023 19:51:11 +0000 Message-Id: <20230302195111.1104185-1-mingxia.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230301192659.601892-1-mingxia.liu@intel.com> References: <20230301192659.601892-1-mingxia.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch updates queue mode info in struct idpf_adapter. Using is_rx_singleq_model to diffentiate rx_singq and rx_splitq explicitly, instead of deducing it from pointer values. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.c | 4 ++-- drivers/common/idpf/idpf_common_device.h | 4 ++-- drivers/common/idpf/idpf_common_rxtx.c | 2 +- drivers/common/idpf/idpf_common_rxtx.h | 3 +++ drivers/net/idpf/idpf_ethdev.c | 4 ++-- drivers/net/idpf/idpf_rxtx.c | 6 +++--- 6 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/common/idpf/idpf_common_device.c b/drivers/common/idpf/idpf_common_device.c index 5475a3e52c..c5e7bbf66c 100644 --- a/drivers/common/idpf/idpf_common_device.c +++ b/drivers/common/idpf/idpf_common_device.c @@ -623,7 +623,7 @@ idpf_vport_info_init(struct idpf_vport *vport, struct idpf_adapter *adapter = vport->adapter; vport_info->vport_type = rte_cpu_to_le_16(VIRTCHNL2_VPORT_TYPE_DEFAULT); - if (adapter->txq_model == 0) { + if (!adapter->is_tx_singleq) { vport_info->txq_model = rte_cpu_to_le_16(VIRTCHNL2_QUEUE_MODEL_SPLIT); vport_info->num_tx_q = @@ -636,7 +636,7 @@ idpf_vport_info_init(struct idpf_vport *vport, vport_info->num_tx_q = rte_cpu_to_le_16(IDPF_DEFAULT_TXQ_NUM); vport_info->num_tx_complq = 0; } - if (adapter->rxq_model == 0) { + if (!adapter->is_rx_singleq) { vport_info->rxq_model = rte_cpu_to_le_16(VIRTCHNL2_QUEUE_MODEL_SPLIT); vport_info->num_rx_q = rte_cpu_to_le_16(IDPF_DEFAULT_RXQ_NUM); diff --git a/drivers/common/idpf/idpf_common_device.h b/drivers/common/idpf/idpf_common_device.h index 364a60221a..c2dc2f16b9 100644 --- a/drivers/common/idpf/idpf_common_device.h +++ b/drivers/common/idpf/idpf_common_device.h @@ -43,8 +43,8 @@ struct idpf_adapter { uint32_t ptype_tbl[IDPF_MAX_PKT_TYPE] __rte_cache_min_aligned; - uint32_t txq_model; /* 0 - split queue model, non-0 - single queue model */ - uint32_t rxq_model; /* 0 - split queue model, non-0 - single queue model */ + bool is_tx_singleq; /* true - single queue model, false - split queue model */ + bool is_rx_singleq; /* true - single queue model, false - split queue model */ /* For timestamp */ uint64_t time_hw; diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c index d7e8df1895..fc87e3e243 100644 --- a/drivers/common/idpf/idpf_common_rxtx.c +++ b/drivers/common/idpf/idpf_common_rxtx.c @@ -309,7 +309,7 @@ idpf_qc_rx_queue_release(void *rxq) return; /* Split queue */ - if (q->bufq1 != NULL && q->bufq2 != NULL) { + if (!q->adapter->is_rx_singleq) { q->bufq1->ops->release_mbufs(q->bufq1); rte_free(q->bufq1->sw_ring); rte_memzone_free(q->bufq1->mz); diff --git a/drivers/common/idpf/idpf_common_rxtx.h b/drivers/common/idpf/idpf_common_rxtx.h index 7e6df080e6..11260d07f9 100644 --- a/drivers/common/idpf/idpf_common_rxtx.h +++ b/drivers/common/idpf/idpf_common_rxtx.h @@ -90,6 +90,9 @@ #define PF_GLTSYN_SHTIME_L_5 (PF_TIMESYNC_BAR4_BASE + 0x138) #define PF_GLTSYN_SHTIME_H_5 (PF_TIMESYNC_BAR4_BASE + 0x13C) +#define IDPF_RX_SPLIT_BUFQ1_ID 1 +#define IDPF_RX_SPLIT_BUFQ2_ID 2 + struct idpf_rx_stats { uint64_t mbuf_alloc_failed; }; diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index 5b4f4fd82b..db58157ba3 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -993,12 +993,12 @@ idpf_parse_devargs(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adap goto bail; ret = rte_kvargs_process(kvlist, IDPF_TX_SINGLE_Q, &parse_bool, - &adapter->base.txq_model); + &adapter->base.is_tx_singleq); if (ret != 0) goto bail; ret = rte_kvargs_process(kvlist, IDPF_RX_SINGLE_Q, &parse_bool, - &adapter->base.rxq_model); + &adapter->base.is_rx_singleq); if (ret != 0) goto bail; diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index d16acd87fb..34205a1025 100644 --- a/drivers/net/idpf/idpf_rxtx.c +++ b/drivers/net/idpf/idpf_rxtx.c @@ -189,9 +189,9 @@ idpf_rx_split_bufq_setup(struct rte_eth_dev *dev, struct idpf_rx_queue *rxq, bufq->ops = &def_rxq_ops; bufq->q_set = true; - if (bufq_id == 1) { + if (bufq_id == IDPF_RX_SPLIT_BUFQ1_ID) { rxq->bufq1 = bufq; - } else if (bufq_id == 2) { + } else if (bufq_id == IDPF_RX_SPLIT_BUFQ2_ID) { rxq->bufq2 = bufq; } else { PMD_INIT_LOG(ERR, "Invalid buffer queue index."); @@ -536,7 +536,7 @@ idpf_rx_queue_init(struct rte_eth_dev *dev, uint16_t rx_queue_id) return -EIO; } - if (rxq->bufq1 == NULL) { + if (rxq->adapter->is_rx_singleq) { /* Single queue */ err = idpf_qc_single_rxq_mbufs_alloc(rxq); if (err != 0) { -- 2.34.1