DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Martzki <mars14850@gmail.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH] lib/bpf: Rename 'bpf_validate' to avoid potential conflict with libpcap
Date: Sun, 5 Mar 2023 09:16:55 -0800	[thread overview]
Message-ID: <20230305091655.05306280@hermes.local> (raw)
In-Reply-To: <20230303135655.78749-1-mars14850@gmail.com>

On Fri,  3 Mar 2023 21:56:54 +0800
Martzki <mars14850@gmail.com> wrote:

> The library libpcap has their function 'bpf_validate' either so
> there would be a multiple definition issue when linking with
> librte_bpf.a and libpcap.a staticly.
> 
> You can reproduce this issue by 'meson build -Dprefer_static=true
> -Denable_apps=test-pmd -Denable_drivers=net/af_xdp,net/af_packet'.
> Notice you need to have a static version of libpcap to reproduce this.
> 
> In 2019 there was a patch reported the same issue but not applied:
> https://inbox.dpdk.org/stable/2601191342CEEE43887BDE71AB9772580148A95BE2@irsmsx105.ger.corp.intel.com/T
> 
> Since 'bpf_validate' is an internal function, I think adding an 'rte'
> prefix is not a good idea and rename it to 'bpf_do_validate' instead.
> 
> Signed-off-by: Martzki <mars14850@gmail.com>

Let's change all the function names here to rte_bpf_XXX.

  reply	other threads:[~2023-03-05 17:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 13:56 Martzki
2023-03-05 17:16 ` Stephen Hemminger [this message]
2023-03-05 17:31   ` Stephen Hemminger
2023-03-06 15:32 ` [PATCH v2] lib/bpf: Rename bpf function names " Martzki
2023-03-06 15:42   ` [PATCH v3] " Martzki
2023-03-11  9:18     ` Thomas Monjalon
2023-03-12  6:20     ` [PATCH v4] " J.J. Martzki
2023-03-12 14:02       ` Konstantin Ananyev
2023-03-13  1:50         ` J.J. Mars
2023-03-13 14:55         ` J.J. Martzki
2023-03-13 15:54           ` Stephen Hemminger
2023-03-13 17:07           ` Konstantin Ananyev
2023-03-13 17:22             ` Stephen Hemminger
2023-03-14  2:21               ` 马尔斯
2023-03-14 14:20       ` [PATCH v5] " J.J. Martzki
2023-03-16  0:58         ` Konstantin Ananyev
2023-03-20 11:50           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230305091655.05306280@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mars14850@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).