From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2908841DEB; Sun, 5 Mar 2023 18:17:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBCC740EF0; Sun, 5 Mar 2023 18:16:59 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id BAB2940EE5 for ; Sun, 5 Mar 2023 18:16:58 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 6-20020a17090a190600b00237c5b6ecd7so10883259pjg.4 for ; Sun, 05 Mar 2023 09:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678036617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OwKnW481Z7wSDknB7fsL2JIZmATQChbaVgSnYRYUwGU=; b=VgM/eSWTndKLDbXUoVbMkkYfVyCXCol4JlfkYRODOFL1IB5AhynZM7jsXcwMNiNuPf 85f35jhYjSbl03+fuOhj4H436ktyMmKW9XJ1aCfNs+ZORf40HjzPGHUDTMYgPflmDwZo YiwdLuwl+1axWJDc1Jm94vHaOQPiL6BIr0Hf9a1/0fMTc81sDJxNrvng/HgJduTR7/5P kgFNzGY28TDNvcz4N5ot4ui3sX+HpvVwUWH4SQZjp7DjPPJLsok33GYx2E5ikyWU1ig3 ma3z7EsV+78BAlIuchhhl5C0LWykNgMnV7FQqFO7d95s9PK8VRpibNGWX/3i440P5N9n HMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678036617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OwKnW481Z7wSDknB7fsL2JIZmATQChbaVgSnYRYUwGU=; b=ED0EOLPwv0al0qoZh5r5ftayyZHs5xPjdrUyUWRb1PfZbwrv95SeFq7x0fYbnZKuNk r63/qnuJvjpWNwtjjvjkBQfmNq0oHSe1Jat7Y6KzepcEPCRbakSI0tpm4p+PvnUestA+ McqvaoNMX/lps3PGXcE6kL6w2taqO3kGS/+jDnDVbDE3gbO1fz3ZydD/tPV1Cgu6M9/P VRGCjihAxyazqL9gm7Ox1kKyYJdY1iR/KKk94pkZR0H9Mwli87fCHcR9QKAJLWLz1vrm +jVdTsseisF7QxeBKf7Y814VksXHMzAW3awunfMxvKsM47HLhnfFbVwVXEkf3mpMJ1cA WofQ== X-Gm-Message-State: AO0yUKXLnQl582H9tRvNQq0q0BoDfC+SFbYyjiMNWlkbJNPdHIcZV9bd 1Gi6x40ecE6w6mdjBgAPTX2U8A== X-Google-Smtp-Source: AK7set/PKjSLxoSQWIcY307grku/AzD1lq3tZ7al9CDUpchGdNcCfo8/DRNJZw0voPxs0b4TiGsBMg== X-Received: by 2002:a17:902:c412:b0:19c:be03:d18b with SMTP id k18-20020a170902c41200b0019cbe03d18bmr12138163plk.22.1678036617662; Sun, 05 Mar 2023 09:16:57 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id lh15-20020a170903290f00b0019aa5528a5csm4992467plb.144.2023.03.05.09.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 09:16:57 -0800 (PST) Date: Sun, 5 Mar 2023 09:16:55 -0800 From: Stephen Hemminger To: Martzki Cc: dev@dpdk.org, Konstantin Ananyev Subject: Re: [PATCH] lib/bpf: Rename 'bpf_validate' to avoid potential conflict with libpcap Message-ID: <20230305091655.05306280@hermes.local> In-Reply-To: <20230303135655.78749-1-mars14850@gmail.com> References: <20230303135655.78749-1-mars14850@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 3 Mar 2023 21:56:54 +0800 Martzki wrote: > The library libpcap has their function 'bpf_validate' either so > there would be a multiple definition issue when linking with > librte_bpf.a and libpcap.a staticly. > > You can reproduce this issue by 'meson build -Dprefer_static=true > -Denable_apps=test-pmd -Denable_drivers=net/af_xdp,net/af_packet'. > Notice you need to have a static version of libpcap to reproduce this. > > In 2019 there was a patch reported the same issue but not applied: > https://inbox.dpdk.org/stable/2601191342CEEE43887BDE71AB9772580148A95BE2@irsmsx105.ger.corp.intel.com/T > > Since 'bpf_validate' is an internal function, I think adding an 'rte' > prefix is not a good idea and rename it to 'bpf_do_validate' instead. > > Signed-off-by: Martzki Let's change all the function names here to rte_bpf_XXX.