From: Simei Su <simei.su@intel.com>
To: beilei.xing@intel.com, yuying.zhang@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org, qiming.yang@intel.com, david.marchand@redhat.com,
Simei Su <simei.su@intel.com>,
stable@dpdk.org
Subject: [PATCH v7] net/i40e: fix max frame size configuration
Date: Mon, 6 Mar 2023 20:18:53 +0800 [thread overview]
Message-ID: <20230306121853.27547-1-simei.su@intel.com> (raw)
In-Reply-To: <20230220075952.444153-1-simei.su@intel.com>
This patch sets max frame size at port level rather than queue level
to avoid unexpected packets received by port.
Fixes: 34fe803c051f ("net/i40e: don't check link status on device start")
Cc: stable@dpdk.org
Signed-off-by: Simei Su <simei.su@intel.com>
---
v7:
* Split v6 patch into two parts:
- David Marchand's revert patch first:
https://patchwork.dpdk.org/project/dpdk/patch/20221213091837.87953-1-david.marchand@redhat.com/
- issue fix patch
* Refine commit title and commit log.
v6:
* Refine commit log.
* Remove return error.
v5:
* Fix misspelling in commit log.
v4:
* Refine commit log.
* Avoid duplicate call to set parameter "wait to complete" true.
v3:
* Put link update before interrupt enable.
v2:
* Refine commit log.
* Add link update.
drivers/net/i40e/i40e_ethdev.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index a982e42..371f422 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1710,11 +1710,6 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused)
*/
i40e_add_tx_flow_control_drop_filter(pf);
- /* Set the max frame size to 0x2600 by default,
- * in case other drivers changed the default value.
- */
- i40e_aq_set_mac_config(hw, I40E_FRAME_SIZE_MAX, TRUE, false, 0, NULL);
-
/* initialize RSS rule list */
TAILQ_INIT(&pf->rss_config_list);
@@ -2332,6 +2327,7 @@ i40e_dev_start(struct rte_eth_dev *dev)
uint32_t intr_vector = 0;
struct i40e_vsi *vsi;
uint16_t nb_rxq, nb_txq;
+ uint16_t max_frame_size;
hw->adapter_stopped = 0;
@@ -2452,7 +2448,7 @@ i40e_dev_start(struct rte_eth_dev *dev)
PMD_DRV_LOG(WARNING, "Fail to set phy mask");
/* Call get_link_info aq command to enable/disable LSE */
- i40e_dev_link_update(dev, 0);
+ i40e_dev_link_update(dev, 1);
}
if (dev->data->dev_conf.intr_conf.rxq == 0) {
@@ -2470,6 +2466,13 @@ i40e_dev_start(struct rte_eth_dev *dev)
"please call hierarchy_commit() "
"before starting the port");
+ max_frame_size = dev->data->mtu ?
+ dev->data->mtu + I40E_ETH_OVERHEAD :
+ I40E_FRAME_SIZE_MAX;
+
+ /* Set the max frame size to HW*/
+ i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, NULL);
+
return I40E_SUCCESS;
tx_err:
--
2.9.5
next prev parent reply other threads:[~2023-03-06 12:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:53 [PATCH] net/i40e: rework maximum " Simei Su
2023-01-16 11:18 ` David Marchand
2023-01-16 12:15 ` Su, Simei
2023-01-20 7:33 ` David Marchand
2023-01-20 13:57 ` Su, Simei
2023-01-20 14:46 ` David Marchand
2023-01-20 15:37 ` Su, Simei
2023-01-31 6:52 ` [PATCH v2] " Simei Su
2023-01-31 7:44 ` 答复: [[SPF Failed]][PATCH " 韩爽
2023-01-31 10:31 ` [PATCH v3] " Simei Su
2023-02-02 5:54 ` Yang, Qiming
2023-02-02 12:30 ` [PATCH v4] " Simei Su
2023-02-02 12:36 ` [PATCH v5] " Simei Su
2023-02-02 12:55 ` David Marchand
2023-02-03 3:50 ` Su, Simei
2023-02-02 13:24 ` David Marchand
2023-02-02 13:48 ` David Marchand
2023-02-03 8:38 ` Yang, Qiming
2023-02-03 8:47 ` David Marchand
2023-02-03 4:00 ` Su, Simei
2023-02-20 7:59 ` [PATCH v6] " Simei Su
2023-02-27 0:35 ` Zhang, Qi Z
2023-02-28 9:36 ` David Marchand
2023-03-02 9:51 ` Zhang, Qi Z
2023-03-22 16:50 ` Kevin Traynor
2023-03-23 14:50 ` Kevin Traynor
2023-03-24 6:32 ` Jiang, YuX
2023-03-24 9:40 ` Kevin Traynor
2023-03-24 10:20 ` Jiang, YuX
2023-03-24 13:07 ` Su, Simei
2023-03-06 12:18 ` Simei Su [this message]
2023-03-07 2:27 ` [PATCH v7] net/i40e: fix max " Zhang, Qi Z
2023-02-02 13:14 ` [PATCH v4] net/i40e: rework maximum " Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306121853.27547-1-simei.su@intel.com \
--to=simei.su@intel.com \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).