From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FBD941DF6; Mon, 6 Mar 2023 21:55:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 052B240EDB; Mon, 6 Mar 2023 21:55:23 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7144240A8A for ; Mon, 6 Mar 2023 21:55:21 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id AFC822057600; Mon, 6 Mar 2023 12:55:20 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AFC822057600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1678136120; bh=azFHYS8fIoGuFDZja3engLueD6z5xpZ8RnRM7iZL+mI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wl3dNZOzmgGTu0g+TrmzpJptzStee9OVU035RhXlRgUZ3YC5OhHcCprl9KPWpIX3v Fcj1+GRmo6jJCKcEoEQklta2ZQHYAhCMa1voJNry9YoFGK3LaC9rI3kwj6IixGClYh uLNI6b6YyiIWlyRJvA+/OvaNqSi1EbIm4QD9+RKM= Date: Mon, 6 Mar 2023 12:55:20 -0800 From: Tyler Retzlaff To: Thomas Monjalon Cc: dev@dpdk.org, Tal Shnaiderman , Matan Azrad , Viacheslav Ovsiienko Subject: Re: [PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables Message-ID: <20230306205520.GA5736@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230105161020.247780-1-thomas@monjalon.net> <6660069.gtipl9YmvM@thomas> <20230303210919.GA20309@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <1728355.M3retTD8dW@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1728355.M3retTD8dW@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 06, 2023 at 09:30:00AM +0100, Thomas Monjalon wrote: > 03/03/2023 22:09, Tyler Retzlaff: > > On Fri, Mar 03, 2023 at 03:12:19PM +0100, Thomas Monjalon wrote: > > > 02/03/2023 18:17, Tyler Retzlaff: > > > > On Thu, Mar 02, 2023 at 02:21:48PM +0100, Thomas Monjalon wrote: > > > > > The DevX library path had to be provided through the variables > > > > > DEVX_INC_PATH and DEVX_LIB_PATH. > > > > > It was non-standard and triggers some issues with recent Meson. > > > > > > > > is it possible for meson to search the default install location that the > > > > devx sdk installation is normally located on windows? then only if you > > > > installed it to some silly non-default location you have to provide > > > > CFLAGS/LDFLAGS? > > > > > > Meson will look into standard system directories I guess, > > > but DevX is never installed in a system directory. > > > Which path do you have in mind? > > > > i think when i install the sdk it goes here by default if i just mash > > the next button. is it wrong to take a look at this path by default? > > > > C:\Program Files\Mellanox\MLNX_WinOF2_DevX_SDK\{inc,lib} > > If we have 2 versions in 2 directories, > and we look at the default location, then we can miss the right one. > I'm afraid such facility induce more complications at the end. oh, didn't realize you can have multiple installations. suppose you could "pick the newest" but maybe that's not terribly sensible.