From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 273E041DF7;
	Mon,  6 Mar 2023 22:00:20 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DAA5140EDB;
	Mon,  6 Mar 2023 22:00:19 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id BAEA340A8A
 for <dev@dpdk.org>; Mon,  6 Mar 2023 22:00:17 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 15EC62057601; Mon,  6 Mar 2023 13:00:17 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 15EC62057601
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1678136417;
 bh=SSwn9xSUDc7lMZJ/mCyeuhlwxHD49A93Z3rLVdZF6s0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Fdhmz4hafWKe0Jzg9GzCYgH6aUSr7ZalWXXApEZcpugy5Qy24ow3eNVc/5TM8UNBd
 unt3u9KQb/cI5xr2Q/buzluu0jyhPiY/NRrOwydHwsey23sQNpL0sSd5lkhY2U9jdd
 wLJraitDiGhcLju6OhqD1aTKIGOabiDAN6HEuZCA=
Date: Mon, 6 Mar 2023 13:00:17 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: luzhipeng <luzhipeng@cestc.cn>, dev@dpdk.org, thomas@monjalon.net
Subject: Re: [PATCH v3] log: add timestamp for log
Message-ID: <20230306210017.GC5736@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230304081421.1352-1-luzhipeng@cestc.cn>
 <20230304080441.4f69905e@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230304080441.4f69905e@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Sat, Mar 04, 2023 at 08:04:41AM -0800, Stephen Hemminger wrote:
> On Sat,  4 Mar 2023 16:14:21 +0800
> luzhipeng <luzhipeng@cestc.cn> wrote:
> 
> > From: Zhipeng Lu <luzhipeng@cestc.cn>
> > 
> > add timestamp for log
> > 
> > Signed-off-by: Zhipeng Lu <luzhipeng@cestc.cn>
> 
> Good idea but:
>   - it needs to be optional
>   - timestamp only makes sense on the terminal (stdout) log stream
>     syslog/journal already have timestamp

+1

also, some people who may have written scripts to consume the log output
might get kind of irritated that you suddenly broke the format of the
output. while not strictly an "api" it's not super friendly to break it
unnecessarily.

> 
> 
> I did a similar patch that never made it in that did this.
> https://patchwork.dpdk.org/project/dpdk/patch/20200814173441.23086-1-stephen@networkplumber.org/