From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AE7041E16; Wed, 8 Mar 2023 03:44:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DFA44113C; Wed, 8 Mar 2023 03:44:14 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 5A24A40ED6 for ; Wed, 8 Mar 2023 03:44:12 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id y2so15287027pjg.3 for ; Tue, 07 Mar 2023 18:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678243451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DY1//aWJlDSkHnHdrWEjX3wZQ65PqyLhSa/ygXnQ+2U=; b=CoEv5kTJUiwzio6NJOmb/EE1LJwWm56yprzJfjneMYWDuFMPq0bM6RPGK+84HPJ5zL Ipn9gxrDyYqeyEq9pLUC6PC8rrR5vq1x1LgXnQwUezlIElKbV39qAH0L5Apq36sgjfEh NgEIytxTjUAa3ZIglwP14+EFh0SzDSloMis/zZ5QB1UIA7ogtmDvzS2O2kvFqR8ffpM6 uGiPs/MzdLJaXTj86QEgwuVOUpv9QeZcBorH/uZ5dSy0OKivkfcdls17/o9+bjrArdhc 74q3ls7NL2VRH7mlZB4Vdr9sJJ+B67Z1y6cYg2KLd7BeyksBTRtnyoVlpLZkIhDbOrQp aKZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678243451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DY1//aWJlDSkHnHdrWEjX3wZQ65PqyLhSa/ygXnQ+2U=; b=McEOM3NsRDC0lXUflV1x1yMsLUYVvA3f+XpgfImNxVAVPWDcYPbgHgGDt3OYk5k7R+ tcchW0ieD+56ZHszdARBg3Ir3U5S/nmtYn+/fTePcjHzUclahFPf7WC5tFp3xpDxi18X cw9eAGvo1W+GEZkoq6WbOZ9IaauabvmPzD/PqzagDssluaJtLQRl9ogZXyO3ZkwvuEZn 6L2YgG0Z6ne/matRfEi3iX1Z7WWRzVMZSUEyXH8ExElt+shhfSOeZf8DDN9HU9ynY+Nl +EAp1pqFZOK7EDCbxe+R/DXp3sK9YIXu5jSiBy1oe+4ZwgC8OGDSwZ34EK5b4PZ0/35T HL4w== X-Gm-Message-State: AO0yUKXOHfIbZrChfUBCtbIYlJstmL2jkSYdlaGH7ulLKlMA3e2NcdEv tB9RFsI7Ve/rhm5r9+txo91qMQ== X-Google-Smtp-Source: AK7set8ao3SmjZDmCQUc1R1tf7J89/dPTMG+dWIBa31LE/7b/pxw02lZvMxlVZq5Vq7+lZ49Hm4PYA== X-Received: by 2002:a17:902:d48e:b0:19a:a520:b1fc with SMTP id c14-20020a170902d48e00b0019aa520b1fcmr21822214plg.14.1678243451409; Tue, 07 Mar 2023 18:44:11 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id ko16-20020a17090307d000b0019472226769sm9016925plb.251.2023.03.07.18.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 18:44:11 -0800 (PST) Date: Tue, 7 Mar 2023 18:44:09 -0800 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, Peng Zhang , stable@dpdk.org Subject: Re: [PATCH] net/nfp: fix MTU configuration order Message-ID: <20230307184409.46daaefb@hermes.local> In-Reply-To: <20230308023318.3041151-1-chaoyong.he@corigine.com> References: <20230308023318.3041151-1-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 8 Mar 2023 10:33:18 +0800 Chaoyong He wrote: > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > index 5922bfea8e..5d92b476e2 100644 > --- a/drivers/net/nfp/nfp_common.c > +++ b/drivers/net/nfp/nfp_common.c > @@ -1126,9 +1126,9 @@ nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > return -EBUSY; > } > > - /* MTU larger then current mbufsize not supported */ > + /* MTU larger than current mbufsize not supported */ > if (mtu > hw->flbufsz) { > - PMD_DRV_LOG(ERR, "MTU (%u) larger then current mbufsize (%u) not supported", > + PMD_DRV_LOG(ERR, "MTU (%u) larger than current mbufsize (%u) not supported", > mtu, hw->flbufsz); > return -ERANGE; > } Patch looks good but this looks like unrelated whitespace change.