From: Stephen Hemminger <stephen@networkplumber.org>
To: Mingxia Liu <mingxia.liu@intel.com>
Cc: dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com
Subject: Re: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode
Date: Wed, 8 Mar 2023 18:41:43 -0800 [thread overview]
Message-ID: <20230308184143.32a8a6d0@hermes.local> (raw)
In-Reply-To: <20230309103142.276726-1-mingxia.liu@intel.com>
On Thu, 9 Mar 2023 10:31:42 +0000
Mingxia Liu <mingxia.liu@intel.com> wrote:
> iff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
> index db58157ba3..59883af8a8 100644
> --- a/drivers/net/idpf/idpf_ethdev.c
> +++ b/drivers/net/idpf/idpf_ethdev.c
> @@ -1058,8 +1058,8 @@ idpf_handle_virtchnl_msg(struct idpf_adapter_ext *adapter_ex)
> struct idpf_ctlq_msg ctlq_msg;
> enum idpf_mbx_opc mbx_op;
> struct idpf_vport *vport;
> - enum virtchnl_ops vc_op;
> uint16_t pending = 1;
> + enum virtchnl_ops vc_op;
> int ret;
>
> while (pending) {
Why does order of declarations matter here?
Compilers are free to reorder this.
next prev parent reply other threads:[~2023-03-09 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:31 Mingxia Liu
2023-03-09 2:41 ` Stephen Hemminger [this message]
2023-03-09 3:03 ` Liu, Mingxia
2023-03-09 10:38 ` [PATCH v2] " Mingxia Liu
2023-03-09 12:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308184143.32a8a6d0@hermes.local \
--to=stephen@networkplumber.org \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=mingxia.liu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).