From: Ivan Malov <ivan.malov@arknetworks.am>
To: dev@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ferruh Yigit <ferruh.yigit@amd.com>,
stable@dpdk.org, Andy Moreton <amoreton@xilinx.com>
Subject: [PATCH 2/2] net/sfc: fix resetting mark in tunnel offload switch rules
Date: Thu, 9 Mar 2023 08:28:42 +0400 [thread overview]
Message-ID: <20230309042842.8709-2-ivan.malov@arknetworks.am> (raw)
In-Reply-To: <20230309042842.8709-1-ivan.malov@arknetworks.am>
The currently used API is unfit for the purpose as it
checks the order in which the action is being added.
Use a dedicated API to request the reset.
Fixes: 012bf708c20f ("net/sfc: support group flows in tunnel offload")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
drivers/net/sfc/sfc_mae.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c
index 3daeed81b9..e5e9257998 100644
--- a/drivers/net/sfc/sfc_mae.c
+++ b/drivers/net/sfc/sfc_mae.c
@@ -3896,12 +3896,10 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,
break;
case SFC_FT_RULE_SWITCH:
/*
- * Packets that go to the rule's AR have FT mark set (from the
- * TUNNEL rule OR's RECIRC_ID). Remove this mark in matching
- * packets. The user may have provided their own action
- * MARK above, so don't check the return value here.
+ * Packets that go to the rule's AR have FT mark set (from
+ * the TUNNEL rule OR's RECIRC_ID). Reset the mark to zero.
*/
- (void)efx_mae_action_set_populate_mark(ctx.spec, 0);
+ efx_mae_action_set_populate_mark_reset(ctx.spec);
ctx.ft_switch_hit_counter =
&spec_mae->ft_ctx->switch_hit_counter;
--
2.17.1
next prev parent reply other threads:[~2023-03-09 4:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 4:28 [PATCH 1/2] common/sfc_efx/base: allow to request MAE mark reset action Ivan Malov
2023-03-09 4:28 ` Ivan Malov [this message]
2023-03-10 14:20 ` [PATCH 2/2] net/sfc: fix resetting mark in tunnel offload switch rules Andrew Rybchenko
2023-03-10 14:20 ` [PATCH 1/2] common/sfc_efx/base: allow to request MAE mark reset action Andrew Rybchenko
2023-03-10 15:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309042842.8709-2-ivan.malov@arknetworks.am \
--to=ivan.malov@arknetworks.am \
--cc=amoreton@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).