DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: mb@smartsharesystems.com, olivier.matz@6wind.com,
	konstantin.v.ananyev@yandex.ru
Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com,
	kamalakshitha.aligeri@arm.com, wathsala.vithanage@arm.com,
	nd@arm.com
Subject: [PATCH 2/4] mempool: clarify comments for mempool cache implementation
Date: Wed,  8 Mar 2023 22:57:36 -0600	[thread overview]
Message-ID: <20230309045738.1261000-3-honnappa.nagarahalli@arm.com> (raw)
In-Reply-To: <20230309045738.1261000-1-honnappa.nagarahalli@arm.com>

Clarify that the mempool cache create and free API implementations
work on user owned mempool caches.

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 lib/mempool/rte_mempool.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
index cf5dea2304..a46d855dbf 100644
--- a/lib/mempool/rte_mempool.c
+++ b/lib/mempool/rte_mempool.c
@@ -757,9 +757,9 @@ mempool_cache_init(struct rte_mempool_cache *cache, uint32_t size)
 }
 
 /*
- * Create and initialize a cache for objects that are retrieved from and
- * returned to an underlying mempool. This structure is identical to the
- * local_cache[lcore_id] pointed to by the mempool structure.
+ * Create and initialize a user owned cache for objects that are retrieved
+ * from and returned to an underlying mempool. This structure is identical
+ * to the local_cache[lcore_id] pointed to by the mempool structure.
  */
 struct rte_mempool_cache *
 rte_mempool_cache_create(uint32_t size, int socket_id)
@@ -786,9 +786,9 @@ rte_mempool_cache_create(uint32_t size, int socket_id)
 }
 
 /*
- * Free a cache. It's the responsibility of the user to make sure that any
- * remaining objects in the cache are flushed to the corresponding
- * mempool.
+ * Free a user owned cache. It's the responsibility of the user to make
+ * sure that any remaining objects in the cache are flushed to the
+ * corresponding mempool.
  */
 void
 rte_mempool_cache_free(struct rte_mempool_cache *cache)
-- 
2.25.1


  parent reply	other threads:[~2023-03-09  4:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  4:57 [PATCH 0/4] Small corrections in mempool Honnappa Nagarahalli
2023-03-09  4:57 ` [PATCH 1/4] mempool: clarify mempool cache flush API behavior Honnappa Nagarahalli
2023-06-07 10:03   ` Morten Brørup
2023-03-09  4:57 ` Honnappa Nagarahalli [this message]
2023-06-07 10:10   ` [PATCH 2/4] mempool: clarify comments for mempool cache implementation Morten Brørup
2023-03-09  4:57 ` [PATCH 3/4] eal: add API to check if lcore id is valid Honnappa Nagarahalli
2023-06-07 10:19   ` Morten Brørup
2023-06-07 15:05     ` Stephen Hemminger
2023-03-09  4:57 ` [PATCH 4/4] mempool: use lcore API to check if lcore ID " Honnappa Nagarahalli
2023-03-09  9:39   ` Konstantin Ananyev
2023-03-10  4:01     ` Honnappa Nagarahalli
2023-03-10 14:06       ` Konstantin Ananyev
2023-06-07  9:35 ` [PATCH 0/4] Small corrections in mempool Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230309045738.1261000-3-honnappa.nagarahalli@arm.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=kamalakshitha.aligeri@arm.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mb@smartsharesystems.com \
    --cc=nd@arm.com \
    --cc=olivier.matz@6wind.com \
    --cc=ruifeng.wang@arm.com \
    --cc=wathsala.vithanage@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).