From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F308941E1C; Thu, 9 Mar 2023 17:21:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D490440ED7; Thu, 9 Mar 2023 17:21:14 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 9C12A40695 for ; Thu, 9 Mar 2023 17:21:13 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id l1so2616125pjt.2 for ; Thu, 09 Mar 2023 08:21:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678378873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=F6Bega6C8RhlmYep+T0fqDa9Nne2SOeHXRl0kCtAsOc=; b=kjMxpnF68QEcWsV/sbbABj2d9NVmCHbO+amb2FQwOR1uxRDH8CXSRvHPOJBXo9QDFg R26Jh1wczoIfShzIYwLB2ERvF/qlLAuYuuz2K4kRTEadKD5I0siHVyiBQMD3WQO+FGQo xA+p1HiV4l+Ef4+4jH7IpERxZzMTKGTmLFo/cZmG4i5+7m3SpQ8Adg1ecx/Y4zoAmIr7 +adZzzkikTUB3kJzVVLTvpsSbS40Shx6WTJbF8zVpbrvZTrv/E9y/SGScirf5c/9d8Oq Y5hM6dJ5DGp3ZA3mKOQZ/iNcdC1AmCBJVq/M45YdgFGBya2h0D76/XjmbkCpnqvAINfm p5Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678378873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F6Bega6C8RhlmYep+T0fqDa9Nne2SOeHXRl0kCtAsOc=; b=d0YpxQDgr4j1pBivzw9dc6jMAwDaKRGdCRZT9/k5oLERxO7JvghZTYJxHTp6ds8Tpa GyA2zyMHVG9DIWmUImzK1p+GJZt2JfW63G0VH3z11GGHxqdMMpBUKmOGTnSBDhdE/4tb mqyZoUHOTeLcx5GuWvo841rEPkgP5r4+D43IbqVo/lxhWre9GIzA3591aZ2PbVJtQsoz npIrKB27L8FIiXgRl7CdRl1wfvk1ybnp1a55F/yOcdtKebGt0X9mzpD2/ToiMImgK+7p Eq3/TZILcfnZDlvUOvoPpSFdv3+iC12/ta+Od8+4V9dFnmUiVS3UYdIpX82DOR7paJzI E71A== X-Gm-Message-State: AO0yUKW4Fpkh/0L9n56qG41Y9XefimK/XPd968FBMmaj9S/gpJCEFnnR 1k1a6gXdQHP/kLlEbRYO+oe7lQ== X-Google-Smtp-Source: AK7set8ZdQCX7YuMJDHEwn07vW1rS8vP6KSuWufgH5pzpR6lFEOIn0cDNexsF0x+oa5R4Czbj+hDtA== X-Received: by 2002:a05:6a20:9146:b0:9d:efbe:52ae with SMTP id x6-20020a056a20914600b0009defbe52aemr21879484pzc.30.1678378872739; Thu, 09 Mar 2023 08:21:12 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 78-20020a630451000000b00502e1c50af3sm11115701pge.45.2023.03.09.08.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 08:21:12 -0800 (PST) Date: Thu, 9 Mar 2023 08:21:11 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH] ethdev: prefer offload names in logs Message-ID: <20230309082111.565105bf@hermes.local> In-Reply-To: <20230309081633.780438-1-david.marchand@redhat.com> References: <20230309081633.780438-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 9 Mar 2023 09:16:33 +0100 David Marchand wrote: > + RTE_ETHDEV_LOG(ERR, "Ethdev port_id=%u requested Rx offloads '%s' in %s(). " > + "Device supports '%s' Rx offloads but does not support '%s'.\n", > + port_id, requested != NULL ? requested : "N/A", __func__, > + available != NULL ? available : "N/A", > + unavailable != NULL ? unavailable : "N/A"); > + free(requested); Please shorten message and make sure it does not cross line boundaries. Best to allow users to do simple search for message.