From: Stephen Hemminger <stephen@networkplumber.org>
To: Yogesh Jangra <yogesh.jangra@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com,
kamalakannan.r@intel.com, harshad.suresh.narayane@intel.com
Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports
Date: Thu, 9 Mar 2023 08:31:09 -0800 [thread overview]
Message-ID: <20230309083109.01baaebb@hermes.local> (raw)
In-Reply-To: <20230309144249.1199517-1-yogesh.jangra@intel.com>
On Thu, 9 Mar 2023 14:42:49 +0000
Yogesh Jangra <yogesh.jangra@intel.com> wrote:
> + /*
> + * SoftNIC runs on the sevice core, it uses the resources from
> + * the testpmd application. When we run quit command, the testpmd
> + * application stops ethdev ports first, SoftNIC will try to
> + * access the port and sometimes that result in segmentation
> + * error. So first closing the SoftNIC port.
> + */
> + RTE_ETH_FOREACH_DEV(pt_id) {
> + if (!strcmp(ports[pt_id].dev_info.driver_name, "net_softnic")) {
> + stop_port(pt_id);
> + close_port(pt_id);
> + }
> + }
> +
NAK
No driver specific hacks please.
Instead fix the driver design or bug please.
next prev parent reply other threads:[~2023-03-09 16:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 14:42 Yogesh Jangra
2023-03-09 16:02 ` [PATCH v2] " Yogesh Jangra
2024-04-18 15:29 ` Ferruh Yigit
2023-03-09 16:31 ` Stephen Hemminger [this message]
2023-03-09 17:19 ` [PATCH] " Dumitrescu, Cristian
2023-03-09 19:09 ` Dumitrescu, Cristian
2023-03-09 20:22 ` Stephen Hemminger
2023-03-10 9:09 ` Singh, Aman Deep
2023-03-10 13:45 ` Dumitrescu, Cristian
2023-03-10 12:00 ` Ferruh Yigit
2023-03-10 13:47 ` David Marchand
2023-03-10 13:47 ` Dumitrescu, Cristian
2023-03-10 13:49 ` David Marchand
2023-03-10 14:36 ` Dumitrescu, Cristian
2023-03-10 14:39 ` David Marchand
2023-03-10 14:58 ` Thomas Monjalon
2023-03-10 13:58 ` Ferruh Yigit
2023-03-10 16:44 ` Stephen Hemminger
2023-03-17 7:11 ` Jangra, Yogesh
2023-03-09 19:08 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309083109.01baaebb@hermes.local \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=harshad.suresh.narayane@intel.com \
--cc=kamalakannan.r@intel.com \
--cc=yogesh.jangra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).