* [PATCH] net/idpf: fix a compiler issue about virtchnl opcode
@ 2023-03-09 11:52 Mingxia Liu
2023-03-09 12:10 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Mingxia Liu @ 2023-03-09 11:52 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, beilei.xing, Mingxia Liu
Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT
will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included
in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed
with virtchnl2 or VIRTCHNL2.
Fixes: 78049b3dc7e6 ("net/idpf: add alarm to handle virtual channel message")
Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
drivers/net/idpf/idpf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index db58157ba3..46aec6ae37 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -1058,8 +1058,8 @@ idpf_handle_virtchnl_msg(struct idpf_adapter_ext *adapter_ex)
struct idpf_ctlq_msg ctlq_msg;
enum idpf_mbx_opc mbx_op;
struct idpf_vport *vport;
- enum virtchnl_ops vc_op;
uint16_t pending = 1;
+ uint32_t vc_op;
int ret;
while (pending) {
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net/idpf: fix a compiler issue about virtchnl opcode
2023-03-09 11:52 [PATCH] net/idpf: fix a compiler issue about virtchnl opcode Mingxia Liu
@ 2023-03-09 12:10 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-03-09 12:10 UTC (permalink / raw)
To: Mingxia Liu; +Cc: jingjing.wu, beilei.xing, dev
On 3/9/2023 11:52 AM, Mingxia Liu wrote:
> Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT
> will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included
> in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed
> with virtchnl2 or VIRTCHNL2.
>
> Fixes: 78049b3dc7e6 ("net/idpf: add alarm to handle virtual channel message")
>
Fixes: d633a4859c98 ("net/idpf: add alarm to handle virtual channel
message")
> Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
Reported-by: Raslan Darawsheh <rasland@nvidia.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-09 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-09 11:52 [PATCH] net/idpf: fix a compiler issue about virtchnl opcode Mingxia Liu
2023-03-09 12:10 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).