From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
Junjie Chen <junjie.j.chen@intel.com>,
Jianfeng Tan <jianfeng.tan@intel.com>,
Cheng Jiang <cheng1.jiang@intel.com>
Subject: [PATCH 1/3] net/vhost: add missing newline in logs
Date: Thu, 9 Mar 2023 13:37:50 +0100 [thread overview]
Message-ID: <20230309123752.2237828-2-david.marchand@redhat.com> (raw)
In-Reply-To: <20230309123752.2237828-1-david.marchand@redhat.com>
Fixes: 3f8ff12821e4 ("vhost: support interrupt mode")
Fixes: 8f1750f42e2d ("net/vhost: perform SW checksum in Rx path")
Fixes: 8ba1723783b2 ("net/vhost: perform SW checksum in Tx path")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/vhost/rte_eth_vhost.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 9c609b45a3..198bf4d1f4 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -297,7 +297,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev)
if (internal->features & (1ULL << VIRTIO_NET_F_CSUM)) {
if (!(rxmode->offloads &
(RTE_ETH_RX_OFFLOAD_UDP_CKSUM | RTE_ETH_RX_OFFLOAD_TCP_CKSUM))) {
- VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance.");
+ VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance.\n");
internal->rx_sw_csum = true;
}
}
@@ -305,7 +305,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev)
if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) {
if (txmode->offloads &
(RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) {
- VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance.");
+ VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance.\n");
internal->tx_sw_csum = true;
}
}
@@ -646,7 +646,7 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t qid)
ret = rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring);
if (ret < 0) {
- VHOST_LOG(ERR, "Failed to get rxq%d's vring", qid);
+ VHOST_LOG(ERR, "Failed to get rxq%d's vring\n", qid);
return ret;
}
VHOST_LOG(INFO, "Disable interrupt for rxq%d\n", qid);
@@ -851,7 +851,7 @@ new_device(int vid)
if (dev_conf->intr_conf.rxq) {
if (eth_vhost_install_intr(eth_dev) < 0) {
VHOST_LOG(INFO,
- "Failed to install interrupt handler.");
+ "Failed to install interrupt handler.\n");
return -1;
}
}
@@ -1191,7 +1191,7 @@ eth_dev_start(struct rte_eth_dev *eth_dev)
if (dev_conf->intr_conf.rxq) {
if (eth_vhost_install_intr(eth_dev) < 0) {
VHOST_LOG(INFO,
- "Failed to install interrupt handler.");
+ "Failed to install interrupt handler.\n");
return -1;
}
}
--
2.39.2
next prev parent reply other threads:[~2023-03-09 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:37 [PATCH 0/3] net/vhost pmd fixes for Rx interrupts David Marchand
2023-03-09 12:37 ` David Marchand [this message]
2023-03-10 3:16 ` [PATCH 1/3] net/vhost: add missing newline in logs Xia, Chenbo
2023-03-09 12:37 ` [PATCH 2/3] net/vhost: fix leak in interrupt handle setup David Marchand
2023-03-10 3:16 ` Xia, Chenbo
2023-03-09 12:37 ` [PATCH 3/3] net/vhost: fix Rx interrupt David Marchand
2023-03-10 7:35 ` Xia, Chenbo
2023-03-13 2:39 ` Yuan, DukaiX
2023-03-14 8:59 ` David Marchand
2023-03-14 11:07 ` Maxime Coquelin
2023-03-16 14:47 ` [PATCH 0/3] net/vhost pmd fixes for Rx interrupts Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309123752.2237828-2-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=junjie.j.chen@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).