From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F80241E25; Thu, 9 Mar 2023 13:38:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF9D342BC9; Thu, 9 Mar 2023 13:38:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6DC8A42BC9 for ; Thu, 9 Mar 2023 13:38:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678365482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XYs3H+a7RghzqGW8iZ6U9viCFj5/hX6Tm9/4jKeAzIk=; b=AliaXDA9yeezF1liwpWkJCSkC/H3j9AuktuAw5Yq9/qSaeP35wksqp9cN2V5vdayka2OBw F8Rf1Aa1GSWWbyh0FwNjQ5gIyAojLOaanvwi+NmwObf9L1yARihgTd0G9E2cvzmWLjt5El j7Co/Jc2JbR1uUr6vKN4m6jDbe3pREA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-WOJdUWLTNI2u1beZgN2mkg-1; Thu, 09 Mar 2023 07:38:00 -0500 X-MC-Unique: WOJdUWLTNI2u1beZgN2mkg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 14735885624; Thu, 9 Mar 2023 12:38:00 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id B935D4010E36; Thu, 9 Mar 2023 12:37:58 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Maxime Coquelin , Chenbo Xia , Junjie Chen , Jianfeng Tan , Cheng Jiang Subject: [PATCH 1/3] net/vhost: add missing newline in logs Date: Thu, 9 Mar 2023 13:37:50 +0100 Message-Id: <20230309123752.2237828-2-david.marchand@redhat.com> In-Reply-To: <20230309123752.2237828-1-david.marchand@redhat.com> References: <20230309123752.2237828-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fixes: 3f8ff12821e4 ("vhost: support interrupt mode") Fixes: 8f1750f42e2d ("net/vhost: perform SW checksum in Rx path") Fixes: 8ba1723783b2 ("net/vhost: perform SW checksum in Tx path") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/vhost/rte_eth_vhost.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 9c609b45a3..198bf4d1f4 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -297,7 +297,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev) if (internal->features & (1ULL << VIRTIO_NET_F_CSUM)) { if (!(rxmode->offloads & (RTE_ETH_RX_OFFLOAD_UDP_CKSUM | RTE_ETH_RX_OFFLOAD_TCP_CKSUM))) { - VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance."); + VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance.\n"); internal->rx_sw_csum = true; } } @@ -305,7 +305,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev) if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) { if (txmode->offloads & (RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) { - VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance."); + VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance.\n"); internal->tx_sw_csum = true; } } @@ -646,7 +646,7 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t qid) ret = rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring); if (ret < 0) { - VHOST_LOG(ERR, "Failed to get rxq%d's vring", qid); + VHOST_LOG(ERR, "Failed to get rxq%d's vring\n", qid); return ret; } VHOST_LOG(INFO, "Disable interrupt for rxq%d\n", qid); @@ -851,7 +851,7 @@ new_device(int vid) if (dev_conf->intr_conf.rxq) { if (eth_vhost_install_intr(eth_dev) < 0) { VHOST_LOG(INFO, - "Failed to install interrupt handler."); + "Failed to install interrupt handler.\n"); return -1; } } @@ -1191,7 +1191,7 @@ eth_dev_start(struct rte_eth_dev *eth_dev) if (dev_conf->intr_conf.rxq) { if (eth_vhost_install_intr(eth_dev) < 0) { VHOST_LOG(INFO, - "Failed to install interrupt handler."); + "Failed to install interrupt handler.\n"); return -1; } } -- 2.39.2