From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D0FE41E23; Thu, 9 Mar 2023 22:31:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3220C41149; Thu, 9 Mar 2023 22:31:35 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 5F6E3410EE for ; Thu, 9 Mar 2023 22:31:33 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id h11-20020a17090a2ecb00b00237c740335cso3196742pjs.3 for ; Thu, 09 Mar 2023 13:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678397492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NhrZ+VhDHiXiSSR1Uk//MLVLNkzGgUFaHv+b3V7eLNw=; b=f9fd3n+FIUIhf2wmyNBfSJacHpaCQoH8q5YdU7mO+d+fMqh469C+aEQjQUDk1E6j+6 277/7lWXTePS7AThA+WE524gos46v7DWyrUX7EcMZERJ+k1AwG59mWpRdL97dxr3bbgu rGGNIyXL9Shnzq+PUzvVuJX/OCqZfHu82ZnO27p5Dciz2NzogYOZenC+X7NdPFx2TvEv cvExS2VQmrekEJLeeVtkREgwSrkVGLCl4y4cIurUBcoCc2ZlsxbvabWbFJT2H/6Z66DB GVRdzlkKBsPRmdCIf7J3ElTsqulgd2yuNgHvNkuXkkIzE+k/H9XPyMlK6uOByljSUz+i 4M3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678397492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NhrZ+VhDHiXiSSR1Uk//MLVLNkzGgUFaHv+b3V7eLNw=; b=K611NRWkcq/GSo3n3thniHPwOrO4ti8QvlOBIQSlbt+YR+NT07uhbG8GZnGCDb6TMR ZwRcjG5Hqqhex5NkGdT2hdLYmUhfuwPaGskeA2iyMqN2itR1uY7OIylvkxs4shpk16eo TDS76lMQ3VFaHDO1vADG8XCEIMVPrBu0Fn3AywlSMCvaZh2HYHiNuXAy/QXa1J5rNKeN TjQ4XqZ7gZkvYe3hMVEjpZP+jy3BlzjreK3xhivlxRaFaj/xTLSFDj+VM80fSCbT3zVP 3kYQgjOejgm94rqDi5N5VhW8KoWAwnjYTXGQxstD3Bg2qX/d0qoV2Y6IjFEVux3B+7++ WREA== X-Gm-Message-State: AO0yUKUEglKYzBWAfaIcd5BY1a/h4rRHp5O2RdbhBcROP/B9eqTuzFkW QK+S/5re72U7HE42rmJEpyzYJj5OEbFaQG1F6mptnw== X-Google-Smtp-Source: AK7set9eWiMuta1dsLCBJhhuivp0pGXpIM7v40BV0XMKWnyo8w8s1gvmQaq2se9P0mQzzydMecbCWQ== X-Received: by 2002:a05:6a20:8e07:b0:cd:d13:8a6e with SMTP id y7-20020a056a208e0700b000cd0d138a6emr27908254pzj.21.1678397492262; Thu, 09 Mar 2023 13:31:32 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id q3-20020a63cc43000000b00502e4015ff7sm64225pgi.23.2023.03.09.13.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 13:31:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff Subject: [PATCH v5 2/9] net/ring: build on Windows Date: Thu, 9 Mar 2023 13:31:21 -0800 Message-Id: <20230309213128.34146-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230309213128.34146-1-stephen@networkplumber.org> References: <20221201014440.11896-1-stephen@networkplumber.org> <20230309213128.34146-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The command line arguments are stored in node_action_pair and the name[] was sized to PATH_MAX which does not exist on Windows. Since the name is either "CREATE" or "ATTACH" it is not related to PATH_MAX (4096). With this fix driver builds ok on windows, but need to modify the test meson build to skip the eventdev test on Windows. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- app/test/meson.build | 2 +- drivers/net/ring/meson.build | 6 ------ drivers/net/ring/rte_eth_ring.c | 3 ++- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 2db5ccf4ff93..5d788148780c 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -391,7 +391,7 @@ if dpdk_conf.has('RTE_NET_BOND') driver_test_names += 'link_bonding_mode4_autotest' endif endif -if dpdk_conf.has('RTE_NET_RING') +if dpdk_conf.has('RTE_LIB_EVENTDEV') and dpdk_conf.has('RTE_NET_RING') test_deps += 'net_ring' test_sources += 'test_pmd_ring_perf.c' test_sources += 'test_pmd_ring.c' diff --git a/drivers/net/ring/meson.build b/drivers/net/ring/meson.build index 72792e26b05a..3534a3cc2287 100644 --- a/drivers/net/ring/meson.build +++ b/drivers/net/ring/meson.build @@ -1,12 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation -if is_windows - build = false - reason = 'not supported on Windows' - subdir_done() -endif - sources = files('rte_eth_ring.c') headers = files('rte_eth_ring.h') pmd_supports_disable_iova_as_pa = true diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index bd5a47dd9017..564d6a726403 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -17,6 +17,7 @@ #define ETH_RING_NUMA_NODE_ACTION_ARG "nodeaction" #define ETH_RING_ACTION_CREATE "CREATE" #define ETH_RING_ACTION_ATTACH "ATTACH" +#define ETH_RING_ACTION_MAX_LEN 8 /* CREATE | ACTION */ #define ETH_RING_INTERNAL_ARG "internal" #define ETH_RING_INTERNAL_ARG_MAX_LEN 19 /* "0x..16chars..\0" */ @@ -539,7 +540,7 @@ eth_dev_ring_create(const char *name, } struct node_action_pair { - char name[PATH_MAX]; + char name[ETH_RING_ACTION_MAX_LEN]; unsigned int node; enum dev_action action; }; -- 2.39.2