DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"Jangra, Yogesh" <yogesh.jangra@intel.com>,
	"Singh, Aman Deep" <aman.deep.singh@intel.com>,
	"Zhang, Yuying" <yuying.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"R, Kamalakannan" <kamalakannan.r@intel.com>,
	"Suresh Narayane, Harshad" <harshad.suresh.narayane@intel.com>
Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports
Date: Fri, 10 Mar 2023 08:44:31 -0800	[thread overview]
Message-ID: <20230310084431.541f2975@hermes.local> (raw)
In-Reply-To: <0e6b3008-142d-20e0-b27d-05ac48fcf2ca@amd.com>

On Fri, 10 Mar 2023 13:58:52 +0000
Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> >>
> >> Why not fix the misbehaving drivers, instead of working around for
> >> softnic, as Stephen suggested?
> >>
> >> Is there a list of problematic drivers?
> >>  
> > 
> > Ferruh, I think this is not a reasonable request. We don't have the expertise to fix all drivers, not the hardware to test all drivers.
> >   
> 
> Please don't make it over dramatic ;), this is not about having
> expertise in all drivers or having their hardware to test.
> 
> You claim some drivers does free up their resources on stop() and
> continue to polling from them cause segfault. Action is move resource
> free from stop() to close().
> 
> And my intention was not request a fix from you, if you have any
> particular misbehaving drivers, I can facilitate a fix from those driver
> maintainers.
> Eventually drivers freeing resources in stop() is a bigger problem and
> can hit other applications too, this is not just testpmd problem.

Lets all work together to resolve this.
I and others are willing to review and fix drivers you identify as problematic.
If this is a common problem, ideally we can update CI infrastructure to
test shutdown and resource issues more thoroughly via ASAN builds etc.

  reply	other threads:[~2023-03-10 16:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 14:42 Yogesh Jangra
2023-03-09 16:02 ` [PATCH v2] " Yogesh Jangra
2024-04-18 15:29   ` Ferruh Yigit
2023-03-09 16:31 ` [PATCH] " Stephen Hemminger
2023-03-09 17:19   ` Dumitrescu, Cristian
2023-03-09 19:09     ` Dumitrescu, Cristian
2023-03-09 20:22     ` Stephen Hemminger
2023-03-10  9:09       ` Singh, Aman Deep
2023-03-10 13:45         ` Dumitrescu, Cristian
2023-03-10 12:00     ` Ferruh Yigit
2023-03-10 13:47       ` David Marchand
2023-03-10 13:47       ` Dumitrescu, Cristian
2023-03-10 13:49         ` David Marchand
2023-03-10 14:36           ` Dumitrescu, Cristian
2023-03-10 14:39             ` David Marchand
2023-03-10 14:58             ` Thomas Monjalon
2023-03-10 13:58         ` Ferruh Yigit
2023-03-10 16:44           ` Stephen Hemminger [this message]
2023-03-17  7:11             ` Jangra, Yogesh
2023-03-09 19:08 ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310084431.541f2975@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=aman.deep.singh@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=harshad.suresh.narayane@intel.com \
    --cc=kamalakannan.r@intel.com \
    --cc=yogesh.jangra@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).