From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AD4C41E65; Fri, 10 Mar 2023 17:44:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 310DC40A8B; Fri, 10 Mar 2023 17:44:35 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id D2A1440685 for ; Fri, 10 Mar 2023 17:44:33 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id p6so6256701plf.0 for ; Fri, 10 Mar 2023 08:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678466673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3JpoZrZKNcBA4eqqepDb0phYhBXPsKDTcGA/rgD39qQ=; b=N9lUSWM7rfXvF1fuLrvYN4ACMnqW2Mmho4MuI+b+RPNzh37sct1wQj41ClMOX1TbN1 bOl3KEdFjpnOFDP8PYQAwqSGWQSeufKFFS+irIyM3rmvzSC8JA9lP9M9bzMPVG0OK02Q HADe/qnMHd5e1OIaDgGFPuvMUkFfUwhckRvh8px+3qOkpFogGHrneLj34kcHaofd6d8T zHM3Pfqlho9Z+tZbI7wIc7zH1HW0XAgiYB/tW+0AGTBSpimF1oFPrbg8ExPbH8LuKdZg oTnmlmWc+Xt8dI9PWIeKh4DMAUJVqGvxTXSSTHwpXHAi4aJ9mD3USu9pB3wgFdgGe5Wu +PhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678466673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3JpoZrZKNcBA4eqqepDb0phYhBXPsKDTcGA/rgD39qQ=; b=nad/GPy94EEX4lihUdO9TndnTmmYJYPez9jixyRu+ApYQnnb3354rOnWHJ5NaJ5sE0 wMItln0VP1KqvGm0LwzgTpD7W3QqE4nOJw5p3BqgPBeaiNk7cHjTIz16+vkIwh1CvRew leum5qo9nLyuyedp9y7Hrhl9x9kaa3gLfMsyETmbZG58DATlYllapuIBn4ExiS1rXWsG 1JWKzXokt+iWSUpDbmJSi1jiRIZ1QuDnyy4ELEK/ByS0qY+SQxbXuOTg7yQlN2CqL0LQ llpCssHVkPEi2EG1U8TNEmf0Bx7fLzLHawOE5rVe6SidACtBCVc8zBLqqr+0tUtL0ZzV aprA== X-Gm-Message-State: AO0yUKWfmmEqqKWhpz7UVLzckOHoybhcBad3FWSo1aK0lMIlj1OIFmtg ZV5+rQnF+yisAwrF9vl8LmgXhQ== X-Google-Smtp-Source: AK7set+M7Q7WfLhdTa/Od4efYs1Dwi42bt1tAGODGHVoXOFNfZPbDTClLj2AWLT+X8rhrdKjBXTlgQ== X-Received: by 2002:a17:902:db02:b0:19c:edcd:26cf with SMTP id m2-20020a170902db0200b0019cedcd26cfmr28074649plx.61.1678466672999; Fri, 10 Mar 2023 08:44:32 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id bf10-20020a170902b90a00b001992e74d058sm276797plb.7.2023.03.10.08.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 08:44:32 -0800 (PST) Date: Fri, 10 Mar 2023 08:44:31 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: "Dumitrescu, Cristian" , "Jangra, Yogesh" , "Singh, Aman Deep" , "Zhang, Yuying" , "dev@dpdk.org" , "R, Kamalakannan" , "Suresh Narayane, Harshad" Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports Message-ID: <20230310084431.541f2975@hermes.local> In-Reply-To: <0e6b3008-142d-20e0-b27d-05ac48fcf2ca@amd.com> References: <20230309144249.1199517-1-yogesh.jangra@intel.com> <20230309083109.01baaebb@hermes.local> <10c16ee4-1c6c-8686-00a6-b5628f415267@amd.com> <0e6b3008-142d-20e0-b27d-05ac48fcf2ca@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 10 Mar 2023 13:58:52 +0000 Ferruh Yigit wrote: > >> > >> Why not fix the misbehaving drivers, instead of working around for > >> softnic, as Stephen suggested? > >> > >> Is there a list of problematic drivers? > >> > > > > Ferruh, I think this is not a reasonable request. We don't have the expertise to fix all drivers, not the hardware to test all drivers. > > > > Please don't make it over dramatic ;), this is not about having > expertise in all drivers or having their hardware to test. > > You claim some drivers does free up their resources on stop() and > continue to polling from them cause segfault. Action is move resource > free from stop() to close(). > > And my intention was not request a fix from you, if you have any > particular misbehaving drivers, I can facilitate a fix from those driver > maintainers. > Eventually drivers freeing resources in stop() is a bigger problem and > can hit other applications too, this is not just testpmd problem. Lets all work together to resolve this. I and others are willing to review and fix drivers you identify as problematic. If this is a common problem, ideally we can update CI infrastructure to test shutdown and resource issues more thoroughly via ASAN builds etc.