DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org, thomas@monjalon.net
Cc: Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: [PATCH] mldev: fix build for aarch32
Date: Fri, 10 Mar 2023 09:57:11 +0100	[thread overview]
Message-ID: <20230310085711.1366455-1-david.marchand@redhat.com> (raw)

Caught by UNH lab, cross compiling for aarch32:

../lib/mldev/mldev_utils_neon.c: In function
	'__float32_to_int8_neon_s8x8':
../lib/mldev/mldev_utils_neon.c:34:10: error: implicit declaration
	of function 'vcvtaq_s32_f32'; did you mean 'vcvtq_s32_f32'?
	[-Werror=implicit-function-declaration]
   34 |  s32x4 = vcvtaq_s32_f32(f32x4);
      |          ^~~~~~~~~~~~~~
      |          vcvtq_s32_f32
../lib/mldev/mldev_utils_neon.c:34:10: error: nested extern declaration
	of 'vcvtaq_s32_f32' [-Werror=nested-externs]
../lib/mldev/mldev_utils_neon.c:34:10: error: incompatible types when
	assigning to type 'int32x4_t' from type 'int'
../lib/mldev/mldev_utils_neon.c:42:10: error: incompatible types when
	assigning to type 'int32x4_t' from type 'int'
   42 |  s32x4 = vcvtaq_s32_f32(f32x4);
      |          ^~~~~~~~~~~~~~

Only compile NEON optimisation for aarch64.

Fixes: fc54766b1612 ("mldev: add Arm NEON type conversion")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/mldev/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build
index 05694b0839..23d108617d 100644
--- a/lib/mldev/meson.build
+++ b/lib/mldev/meson.build
@@ -8,7 +8,7 @@ sources = files(
         'mldev_utils_scalar.c',
 )
 
-if arch_subdir == 'arm'
+if dpdk_conf.has('RTE_ARCH_ARM64')
     sources += files('mldev_utils_neon.c')
 endif
 
-- 
2.39.2


             reply	other threads:[~2023-03-10  8:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10  8:57 David Marchand [this message]
2023-03-10  9:32 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310085711.1366455-1-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=syalavarthi@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).