DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 23.07 2/2] build: explicitly track file paths in current directory
Date: Fri, 10 Mar 2023 11:11:38 +0000	[thread overview]
Message-ID: <20230310111138.92282-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20230310111138.92282-1-bruce.richardson@intel.com>

To ensure proper path tracking for files being used by the build, the
"files()" function should always be used. While meson currently assumes
that bare filenames passed to commands refer to paths in the current
directory, other reimplementations of meson, e.g. muon, require the
paths to be properly tracked. Therefore, for resiliency, ensure all
paths are specified using "files()".

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/meson.build              | 2 +-
 buildtools/pkg-config/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/meson.build b/app/test/meson.build
index 2db5ccf4ff..94233fafca 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -470,7 +470,7 @@ dpdk_test = executable('dpdk-test',
              driver_install_path),
         install: true)

-has_hugepage = run_command(py3, 'has_hugepage.py', check: true).stdout().strip() != '0'
+has_hugepage = run_command(py3, files('has_hugepage.py'), check: true).stdout().strip() != '0'
 message('hugepage availability: @0@'.format(has_hugepage))

 # some perf tests (eg: memcpy perf autotest)take very long
diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build
index 0412883c8f..b36add17e3 100644
--- a/buildtools/pkg-config/meson.build
+++ b/buildtools/pkg-config/meson.build
@@ -56,4 +56,4 @@ This is required for a number of static inline functions in the public headers.'

 # For static linking with dependencies as shared libraries,
 # the internal static libraries must be flagged explicitly.
-run_command(py3, 'set-static-linker-flags.py', check: true)
+run_command(py3, files('set-static-linker-flags.py'), check: true)
--
2.37.2


  parent reply	other threads:[~2023-03-10 11:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 11:11 [PATCH 23.07 0/2] Minor meson build improvements Bruce Richardson
2023-03-10 11:11 ` [PATCH 23.07 1/2] build: fix case of project language name Bruce Richardson
2023-03-13 23:50   ` Tyler Retzlaff
2023-03-10 11:11 ` Bruce Richardson [this message]
2023-03-13 23:50   ` [PATCH 23.07 2/2] build: explicitly track file paths in current directory Tyler Retzlaff
2023-05-24 20:24 ` [PATCH 23.07 0/2] Minor meson build improvements Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310111138.92282-3-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).