From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6046041E80; Sun, 12 Mar 2023 18:09:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EEAE410D1; Sun, 12 Mar 2023 18:09:14 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id B5D2B406A2 for ; Sun, 12 Mar 2023 18:09:12 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id A6A9141E81; Sun, 12 Mar 2023 18:09:12 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1180] TestPMD shell get stuck Date: Sun, 12 Mar 2023 17:09:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: testpmd X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: pdamouny@nvidia.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16786409520.A9EC.3806263 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16786409520.A9EC.3806263 Date: Sun, 12 Mar 2023 18:09:12 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1180 Bug ID: 1180 Summary: TestPMD shell get stuck Product: DPDK Version: unspecified Hardware: x86 OS: Windows Status: UNCONFIRMED Severity: major Priority: Normal Component: testpmd Assignee: dev@dpdk.org Reporter: pdamouny@nvidia.com Target Milestone: --- from the commit 0fd1386c30c3ad9365d7fdd2829bf7cb2e1b9dff when entering testpmd with interactive mode=20 while writing the shell get stuck and cant enter or CTRL C --=20 You are receiving this mail because: You are the assignee for the bug.= --16786409520.A9EC.3806263 Date: Sun, 12 Mar 2023 18:09:12 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1180
Summary TestPMD shell get stuck
Product DPDK
Version unspecified
Hardware x86
OS Windows
Status UNCONFIRMED
Severity major
Priority Normal
Component testpmd
Assignee dev@dpdk.org
Reporter pdamouny@nvidia.com
Target Milestone --- 

from the commit 0fd1386c30c3ad9365=
d7fdd2829bf7cb2e1b9dff

when entering testpmd with interactive mode=20
while writing the shell get stuck and cant enter or CTRL C

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --16786409520.A9EC.3806263-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E281741E08; Sun, 12 Mar 2023 22:39:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 968F3427E9; Sun, 12 Mar 2023 22:39:56 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 5E78A427E9 for ; Sun, 12 Mar 2023 22:39:55 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id p6so10964335plf.0 for ; Sun, 12 Mar 2023 14:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678657194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2hPVVa9TSRHFC0cj9sX7l7O3iY5cLU3lJy8WTxmhHxA=; b=m7enWiUiU4cEyA+39Gq+Nq5qW/zjeO7XeS2f5kdWNfCege+5tGolYpORKlFoUpXb3d eaZEKzZhyZRewC9EXQVj58WiyhfLDXR3gINtHEGkEkPsB4Xfl2/2ndNtmARGuNaUjN3H YN+Vp+rHmxj88vVxHAjI8ttZAqVykeuucW8L7UBaPTLprUrs3sbD7rYyX1NR4NrTgU86 ytIGcktjSb2+pj7OG8q6mOu5paFWqHG9dWoexJXeWM8aiq654i7YM03yLqspTyFXsiZA 7Fszih+P6/CNnB+Z0S1xEpg0ICk0p6qJSFrTlAI0kPZi2NpWqziUae+fTcJyfK6/zoL3 svjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678657194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2hPVVa9TSRHFC0cj9sX7l7O3iY5cLU3lJy8WTxmhHxA=; b=6sr7VxvSg3vBbDOzxY9kpeJD4KrfAZJGxlNE/vFMSwprAp5HGBDqSOmreANyfH5/mD zzW2pk6Jgzg7lHvbwUCJlud5Kdmk05rU+msEgOeB0bGmHMn+fk0ghgVKKig6FlFVHKXT zEQvd+ImSWgvXxOB1Etd9B/3Swtr0NSVK8il+aZ4XbXacpuIIAmFU8UeYxJgfYxaJyHY DLy+t3bP70Dxr+kBJv7Sl5j2H835e58yopy5604DTliAwgZdjXrjjJoq6FHr1cGGt0Iq Ufo4HHaGPAtkQT36TwLNw6JoXnzOd+8+c0p1pNbDR5sOTDe2kLvEWwdZhkTe+nA5QCgY iIOA== X-Gm-Message-State: AO0yUKV8lBgdQK/ItOr21zQzUI+sRD4og0lRmDidFM2Z9KOr/w1N0tnu U0W0C44mSxbg1KAJFeQhgXmOWKv/c09Bd7Q212BLiQ== X-Google-Smtp-Source: AK7set+6n2qXKq7cJonVlMh3BtsrTacbwy8T9/ch+lKuI4KKvUMgYEBNyg18p7SkW+P2i7CuTMb/9w== X-Received: by 2002:a17:902:d4c3:b0:19c:c184:d211 with SMTP id o3-20020a170902d4c300b0019cc184d211mr39314869plg.37.1678657194262; Sun, 12 Mar 2023 14:39:54 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id a14-20020a170902ecce00b0019aafc42328sm3253383plh.153.2023.03.12.14.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 14:39:54 -0700 (PDT) Date: Sun, 12 Mar 2023 14:39:52 -0700 From: Stephen Hemminger To: bugzilla@dpdk.org Cc: dev@dpdk.org Subject: Re: [Bug 1180] TestPMD shell get stuck Message-ID: <20230312143952.248a2fc4@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 12 Mar 2023 17:09:12 +0000 bugzilla@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=1180 > > Bug ID: 1180 > Summary: TestPMD shell get stuck > Product: DPDK > Version: unspecified > Hardware: x86 > OS: Windows > Status: UNCONFIRMED > Severity: major > Priority: Normal > Component: testpmd > Assignee: dev@dpdk.org > Reporter: pdamouny@nvidia.com > Target Milestone: --- > > from the commit 0fd1386c30c3ad9365d7fdd2829bf7cb2e1b9dff > > when entering testpmd with interactive mode > while writing the shell get stuck and cant enter or CTRL C > IANAW (I am not a Windows Programmer) Is there a way to read from stdin and get interrupted if Ctrl C is hit. On Linux, this requires doing select() then do a read() since the default behaviour is to restart the read() on signal. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8264F41E82; Mon, 13 Mar 2023 00:01:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32BE2406BC; Mon, 13 Mar 2023 00:01:58 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 0DAD640151 for ; Mon, 13 Mar 2023 00:01:55 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id d13so162418pjh.0 for ; Sun, 12 Mar 2023 16:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678662115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=V+C3cfbaYpSL7tO4hcOnI7yUrtuFflnMEuL3QPN2SuQ=; b=cB3skvoosIC9K07aqfJ80S/Kihc+DwXHBdsOX6tPTRCNxb9HDR7mtAWPgZ0VIPPS2i /LrQodlCIFrYA2h2D3tk6ypokB8HoLdmcnzIWTjeyUo8zw/uYy/975F9gDjjABBsgzwB rgKXRsijL6lZIh80Naz3gmz8aaLts72lCzOAttmPjyjihGwMX2kVZCsI82RQ2wwLTQyY d6/F9YwpM6Z0q7y33Kk6W0gfzWwLe3l2pTxLdwYRZuzZU/T1l/b32hdWp982APj1qsai DNdIGpyfHsbwVnWMuBYrKb3rfepV/UYsh9PQLp1qSjT8X+5DOr4HQtkQchZGsK4hDKlG zMQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678662115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V+C3cfbaYpSL7tO4hcOnI7yUrtuFflnMEuL3QPN2SuQ=; b=1hJp/c2Pc7fBHRBEOo1A+hjCso6kBwfcQM6f6W55mM050EUyvJMLe9WC1Ulcht7ID1 EikU+re4aT0Ky5B/e2xta8ezXLehovUOuyJznngDQYY7zinDQ409eO9w5V+mo+Z7OFjW CysCAFV8xS9crvGYTJaKOwdyWu34Y8nPJoWc/lUOs/vD1sUcfIlmyRblUxn7BISqFvmA PlXKkDdRQGc9PL9jA9TdPgzCDnr4IYkr8OCol0QkaWX7R6S6CTgjJX7k6L21Elazhev2 IYmH1Odq8B7E6HMYlpP8zyWquUWZ44qM6BeyQqd/5i7AJenQArppyJW5DcFbPumUVeg1 9dCg== X-Gm-Message-State: AO0yUKXVSQFOYEKENWM/WFGoDXZ4g28ja/qD6rtCUvljluKs+wNnWCHg /PZIBm/ji86w0rT1dpHhzavg1w== X-Google-Smtp-Source: AK7set9r9vYsmSEhIlInRFZkCLRelgtSNNqsXXxcNsWzrv/0Da+GTUUYJLzSlhFgRrMpNL8KITDARg== X-Received: by 2002:a17:903:120d:b0:1a0:49e2:df91 with SMTP id l13-20020a170903120d00b001a049e2df91mr1711759plh.0.1678662114967; Sun, 12 Mar 2023 16:01:54 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id lk15-20020a17090308cf00b001898ee9f723sm3357357plb.2.2023.03.12.16.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 16:01:54 -0700 (PDT) Date: Sun, 12 Mar 2023 16:01:52 -0700 From: Stephen Hemminger To: bugzilla@dpdk.org Cc: dev@dpdk.org Subject: Re: [Bug 1180] TestPMD shell get stuck Message-ID: <20230312160152.118418dc@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 12 Mar 2023 17:09:12 +0000 bugzilla@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=3D1180 >=20 > Bug ID: 1180 > Summary: TestPMD shell get stuck > Product: DPDK > Version: unspecified > Hardware: x86 > OS: Windows > Status: UNCONFIRMED > Severity: major > Priority: Normal > Component: testpmd > Assignee: dev@dpdk.org > Reporter: pdamouny@nvidia.com > Target Milestone: --- >=20 > from the commit 0fd1386c30c3ad9365d7fdd2829bf7cb2e1b9dff >=20 > when entering testpmd with interactive mode=20 > while writing the shell get stuck and cant enter or CTRL C >=20 Try this patch, it works on Linux. Sorry, don't have time or setup to run D= PDK on Windows. I am totally volunteer on the project now. =46rom f3410ed290c2f2b1981be289a121089366edcb4c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Sun, 12 Mar 2023 15:58:14 -0700 Subject: [PATCH] testpmd: make sure ctrl-c causes SIGINT The setting in terminal handling for both Unix style and Windows was not ensuring that Ctrl-C character would cause interrupt. Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") Bugzilla ID: 1180 Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline_os_unix.c | 3 ++- lib/cmdline/cmdline_os_windows.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/cmdline/cmdline_os_unix.c b/lib/cmdline/cmdline_os_unix.c index 64a945a34fb3..755a6141546d 100644 --- a/lib/cmdline/cmdline_os_unix.c +++ b/lib/cmdline/cmdline_os_unix.c @@ -16,7 +16,8 @@ terminal_adjust(struct cmdline *cl) tcgetattr(0, &cl->oldterm); =20 memcpy(&term, &cl->oldterm, sizeof(term)); - term.c_lflag &=3D ~(ICANON | ECHO | ISIG); + term.c_lflag &=3D ~(ICANON | ECHO); + term.c_lflag |=3D ISIG; tcsetattr(0, TCSANOW, &term); =20 setbuf(stdin, NULL); diff --git a/lib/cmdline/cmdline_os_windows.c b/lib/cmdline/cmdline_os_wind= ows.c index 73ed9ba290b8..be11409029a2 100644 --- a/lib/cmdline/cmdline_os_windows.c +++ b/lib/cmdline/cmdline_os_windows.c @@ -32,10 +32,10 @@ terminal_adjust(struct cmdline *cl) mode &=3D ~( ENABLE_LINE_INPUT | /* no line buffering */ ENABLE_ECHO_INPUT | /* no echo */ - ENABLE_PROCESSED_INPUT | /* pass Ctrl+C to program */ ENABLE_MOUSE_INPUT | /* no mouse events */ ENABLE_WINDOW_INPUT); /* no window resize events */ - mode |=3D ENABLE_VIRTUAL_TERMINAL_INPUT; + mode |=3D ENABLE_VIRTUAL_TERMINAL_INPUT | + ENABLE_PROCESSED_INPUT; /* Ctrl C processed by the system */ SetConsoleMode(handle, mode); } =20 --=20 2.39.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 343284280A; Wed, 22 Mar 2023 10:36:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AC6E40E09; Wed, 22 Mar 2023 10:36:38 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 8985A40A84 for ; Wed, 22 Mar 2023 10:36:36 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 7CFA24280D; Wed, 22 Mar 2023 10:36:36 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1180] TestPMD shell get stuck Date: Wed, 22 Mar 2023 09:36:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: testpmd X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: pdamouny@nvidia.com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: multipart/alternative; boundary=16794777962.5c84AD.1673810 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16794777962.5c84AD.1673810 Date: Wed, 22 Mar 2023 10:36:36 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1180 Pier Damouny (pdamouny@nvidia.com) changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #6 from Pier Damouny (pdamouny@nvidia.com) --- the issue was solved by commit=20 f1d0993e034e39968a2c80a8561b46c260c27487 https://github.com/Mellanox/dpdk.org/commit/f1d0993e034e39968a2c80a8561b46c= 260c27487 --=20 You are receiving this mail because: You are the assignee for the bug.= --16794777962.5c84AD.1673810 Date: Wed, 22 Mar 2023 10:36:36 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All Pier Damouny changed bug 1180
What Removed Added
Resolution --- FIXED
Status UNCONFIRMED RESOLVED

Comment # 6 on bug 1180 from = Pier Damouny 
the issue was solved by commit=20
f1d0993e034e39968a2c80a8561b46c260c27487

https://github.com/Mellanox/dpdk.org/commit/f1d0993e0=
34e39968a2c80a8561b46c260c27487

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --16794777962.5c84AD.1673810--