From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42C8F41E1D; Mon, 13 Mar 2023 16:51:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 205EC40ED4; Mon, 13 Mar 2023 16:51:10 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 1F39B406BC for ; Mon, 13 Mar 2023 16:51:08 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id j3-20020a17090adc8300b0023d09aea4a6so3012775pjv.5 for ; Mon, 13 Mar 2023 08:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678722667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=VGNAeG2VWmm7O08wBG8aXkH4NXN53Tf71F5EL9oU9vc=; b=ULfRmTupLET6nOZkFXHtpfrgWfcd9gIVdIWe3e+4h7z2qShLV3ZsSRHC0de3WcWKdq Q7VOhy3VV8RlpkzpN/kE7LFWL3BpmpyPNivVn3h+im1DIiLsOw0xx+DRxL6eYgShzr8H 9YUA0DCgyzm//AJ2nqmo+obthjEB5XiOGf5dqlLG1KBKVhXUNz1QVTNV+9uW5om/heL3 VCeECVocKiqcIAOELfvI8BM8zySk8NEy6oAQvHAg7a6QUznvmQPKZEmZN21XiI1kZTjU N8z3Ki8ca/4A+luq16VsZd1fQD3zYbgWAzi+upGhmwEDyAYt3eAuL532afJhPn+MXUl7 1kDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678722667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VGNAeG2VWmm7O08wBG8aXkH4NXN53Tf71F5EL9oU9vc=; b=e6m7VHM4tDr7kXigC5zYKo4VuuREpok3yqTf/3Avi3QR6qEkyvgzQnvaGHSM8qGGqE uKMrp3oVfG+FvKBsmVDjgnz1UHqeigk8/4WKrmcW9trnCjOorMpO0qsFsMOHneiqeVT5 cITGj7O5QjUVUl9teWP6orCEI/GWTMZ8OlTC/aC3apNqyLMf/4a5jjHDnbXkh8ATtTrF ZvYMXoBcQN9JVlBaqnwXuwWzXMCRDzFa6JFWzIcQtfBmJexCMfcdtYoDx0Mn+SZBOaq6 zLcrYbdmuErN/i7wM7HVTM87GE04VEewYQwsWz7L3slirxp7Yv4cSct52VTpvhUvTcIn /QbA== X-Gm-Message-State: AO0yUKVL0ir4BH2fVXmYgzQG/nqYUny9SgZG57tbePia2kSy63bpMVfr MgNXuewVpt+4p8jI4gFIcDW5SA== X-Google-Smtp-Source: AK7set93Gswj0QFzKqLohshzxp1cK8IEeqBLuMcGTn6wulcm3LLIuMpAbIocL/5cABszrNX9S5jsAA== X-Received: by 2002:a05:6a20:8f08:b0:c7:6a98:5bdc with SMTP id b8-20020a056a208f0800b000c76a985bdcmr45021778pzk.16.1678722667260; Mon, 13 Mar 2023 08:51:07 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id p190-20020a6342c7000000b0050b19d24c3bsm1698885pga.37.2023.03.13.08.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 08:51:07 -0700 (PDT) Date: Mon, 13 Mar 2023 08:51:05 -0700 From: Stephen Hemminger To: Volodymyr Fialko Cc: , Reshma Pattan , David Marchand , Andrew Rybchenko , , Subject: Re: [PATCH] reorder: fix registration of dynamic field in mbuf Message-ID: <20230313085105.65a0320e@hermes.local> In-Reply-To: <20230313093450.2560058-1-vfialko@marvell.com> References: <20230313093450.2560058-1-vfialko@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 13 Mar 2023 10:34:50 +0100 Volodymyr Fialko wrote: > +rte_reorder_dynf_register(void) > +{ > + int ret; > + > + static const struct rte_mbuf_dynfield reorder_seqn_dynfield_desc = { > + .name = RTE_REORDER_SEQN_DYNFIELD_NAME, > + .size = sizeof(rte_reorder_seqn_t), > + .align = __alignof__(rte_reorder_seqn_t), > + }; > + This does not need to be static, can just be on stack variable.