From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 23.07 1/2] build: fix case of project language name
Date: Mon, 13 Mar 2023 16:50:37 -0700 [thread overview]
Message-ID: <20230313235037.GA23962@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20230310111138.92282-2-bruce.richardson@intel.com>
On Fri, Mar 10, 2023 at 11:11:37AM +0000, Bruce Richardson wrote:
> According to the meson manual [1], the project language should be given
> as 'c', rather than 'C' in the initial "project" function call. While
> meson itself does not complain about this, the "muon" project, which
> attempts to re-implement meson in C, does complain.
>
> /home/bruce/dpdk/meson.build:4:17: error 'C' is not a valid language
> 4 | project('DPDK', 'C',
> ^
>
> [1] https://mesonbuild.com/Reference-manual_functions.html#project
>
> Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
>
> Signed-off-by: Bruce richardson <bruce.richardson@intel.com>
> ---
Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
next prev parent reply other threads:[~2023-03-13 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 11:11 [PATCH 23.07 0/2] Minor meson build improvements Bruce Richardson
2023-03-10 11:11 ` [PATCH 23.07 1/2] build: fix case of project language name Bruce Richardson
2023-03-13 23:50 ` Tyler Retzlaff [this message]
2023-03-10 11:11 ` [PATCH 23.07 2/2] build: explicitly track file paths in current directory Bruce Richardson
2023-03-13 23:50 ` Tyler Retzlaff
2023-05-24 20:24 ` [PATCH 23.07 0/2] Minor meson build improvements Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313235037.GA23962@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).