From: Wenjing Qiao <wenjing.qiao@intel.com>
To: Yuying.Zhang@intel.com, beilei.xing@intel.com
Cc: dukaix.yuan@intel.com, dev@dpdk.org,
Wenjing Qiao <wenjing.qiao@intel.com>
Subject: [PATCH v2] net/i40e: fix MAC loopback on X722
Date: Mon, 13 Mar 2023 23:16:19 -0400 [thread overview]
Message-ID: <20230314031619.12057-1-wenjing.qiao@intel.com> (raw)
In-Reply-To: <20230314030544.6664-1-wenjing.qiao@intel.com>
If enabling MAC loopback mode on X722 NIC, transmitted packets are not
seen in the receive queue. The root cause is using wrong loopback mode
bits. Correct it according to the X722 datasheet.
Fixes: 3a838ab649df ("net/i40e: support MAC loopback")
Fixes: 5712e6407089 ("net/i40e: revert enhancing loopback AQ command")
Signed-off-by: Wenjing Qiao <wenjing.qiao@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 17 ++++++++++++++---
drivers/net/i40e/i40e_ethdev.h | 3 +++
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index a982e42264..d742fd0d2b 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2415,10 +2415,21 @@ i40e_dev_start(struct rte_eth_dev *dev)
}
}
+ /* Disable mac loopback mode */
+ if (dev->data->dev_conf.lpbk_mode == I40E_AQ_LB_MODE_NONE) {
+ ret = i40e_aq_set_lb_modes(hw, I40E_AQ_LB_MODE_NONE, NULL);
+ if (ret != I40E_SUCCESS) {
+ PMD_DRV_LOG(ERR, "fail to set loopback link");
+ goto tx_err;
+ }
+ }
+
/* Enable mac loopback mode */
- if (dev->data->dev_conf.lpbk_mode == I40E_AQ_LB_MODE_NONE ||
- dev->data->dev_conf.lpbk_mode == I40E_AQ_LB_PHY_LOCAL) {
- ret = i40e_aq_set_lb_modes(hw, dev->data->dev_conf.lpbk_mode, NULL);
+ if (dev->data->dev_conf.lpbk_mode == I40E_AQ_LB_MODE_EN) {
+ if (hw->mac.type == I40E_MAC_X722)
+ ret = i40e_aq_set_lb_modes(hw, I40E_AQ_LB_MAC_LOCAL_X722, NULL);
+ else
+ ret = i40e_aq_set_lb_modes(hw, I40E_AQ_LB_MAC, NULL);
if (ret != I40E_SUCCESS) {
PMD_DRV_LOG(ERR, "fail to set loopback link");
goto tx_err;
diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
index 7c4cc44a27..9b806d130e 100644
--- a/drivers/net/i40e/i40e_ethdev.h
+++ b/drivers/net/i40e/i40e_ethdev.h
@@ -48,6 +48,9 @@
#define I40E_MAX_VF 128
/*flag of no loopback*/
#define I40E_AQ_LB_MODE_NONE 0x0
+#define I40E_AQ_LB_MODE_EN 0x01
+#define I40E_AQ_LB_MAC 0x01
+#define I40E_AQ_LB_MAC_LOCAL_X722 0x04
/*
* vlan_id is a 12 bit number.
* The VFTA array is actually a 4096 bit array, 128 of 32bit elements.
--
2.25.1
next prev parent reply other threads:[~2023-03-14 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 3:05 [PATCH] net/i4oe: " Wenjing Qiao
2023-03-14 3:16 ` Wenjing Qiao [this message]
2023-03-16 2:05 ` [PATCH v2] net/i40e: " Yuan, DukaiX
2023-03-16 2:21 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314031619.12057-1-wenjing.qiao@intel.com \
--to=wenjing.qiao@intel.com \
--cc=Yuying.Zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=dukaix.yuan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).