From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E21641EB1; Thu, 16 Mar 2023 16:31:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C62F42D4B; Thu, 16 Mar 2023 16:31:07 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 65EA340DF6 for <dev@dpdk.org>; Thu, 16 Mar 2023 16:31:06 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id cn6so2004309pjb.2 for <dev@dpdk.org>; Thu, 16 Mar 2023 08:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1678980665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1zxjqFqGrKhquDT5WRqoJvHzTIeG6ksSyxUS/D/uANA=; b=FrM90oqe5PTgnsrjH52iyJeB2PXS5GzTA4RoGamtjb13EobSM7sz3CodUFgYQT8qu3 LUG2ryAVnq85HpPiBInbXEoo0/HtXs3NeBofAKVJs+5WrGlNEGfoTEw4GRv9ay0WvtJR x9rdXSvwpv3Wp/vu0rCKnuW+rcTPIEfG+EjmULc00Pm0nUHscmVtOY2IH0DAMV+AUW1l 3H+n9MwVqIRsPzk8ub1HcOhI8tbmFqckqaKoj/L+LdegTEyCuwr6JatJpLyg8lXsZgVv kbxPKogaPRwmEWzYE9RABhf92gkPcr9WQtpFgs1T4Rdr9ZbPnmB3wVzvrlWg4OyAX5qW KQzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678980665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1zxjqFqGrKhquDT5WRqoJvHzTIeG6ksSyxUS/D/uANA=; b=3gs4sSp1fQsmrV+Tgt0Qrig/voBikC4YiPg4tRJKp6bBLmweeE66c9tazdnkNlH8Iv aNSbP3Hr+5YL9iGyPcgDerP6A0IuuJgCkG3CUswdPhYkd6azpn3MdJm+BdfLHLSt1oPl s++GIfU5BPb4DX8+uTDQSRT7hchMMr+DMTeQedGnBvKqD7Lsp1GS3Ytc6iTYo5XsPKjW MG53WNRtBR28numCNekP4uR47KZV7Hk1z436vdVxpP8Gy6ZHbfKTpn41ZgGFzTIgSbHe CQRHRQLYYxna1oK6VjNzUFDsRjPtskjF+OTCr76llT3vhycSahg0uFidl0FC7C9Kp/G7 QxxQ== X-Gm-Message-State: AO0yUKWeDfasS7W5FRy3J6Lghwfc2FdlnTrS7iq2ckYRzpLFHYHTfuVJ ZUKxh4yonWOdNbxjTa/GR2aUtw== X-Google-Smtp-Source: AK7set/3TZGk7pxezX4nT/dPG1j7ulpBQN31YGwL6ypVVdK6Kb/rulwZJee0gNv8sGiSRY67lPFMrA== X-Received: by 2002:a17:90b:1c85:b0:23d:1143:1e3c with SMTP id oo5-20020a17090b1c8500b0023d11431e3cmr4369718pjb.44.1678980665516; Thu, 16 Mar 2023 08:31:05 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id g2-20020a17090adac200b00233cde36909sm3367118pjx.21.2023.03.16.08.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 08:31:05 -0700 (PDT) Date: Thu, 16 Mar 2023 08:31:04 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>, Pier Damouny <pdamouny@nvidia.com> Subject: Re: [PATCH v4 0/2] Fix testpmd interrupt regression Message-ID: <20230316083104.3872a538@hermes.local> In-Reply-To: <fb66c0b6-8e54-df27-6233-507a9bd3f843@amd.com> References: <20230313171905.67720-1-stephen@networkplumber.org> <20230315173132.4044-1-stephen@networkplumber.org> <fb66c0b6-8e54-df27-6233-507a9bd3f843@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 16 Mar 2023 12:20:41 +0000 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > On 3/15/2023 5:31 PM, Stephen Hemminger wrote: > > Resolve issues from using control-C in testpmd. > > Fixes regression from recent change to use cmdline_poll(). > > > > v4 - drop sig_atomic_t. Not required requires changes on > > some platforms. > > > > Stephen Hemminger (2): > > testpmd: go back to using cmdline_interact > > testpmd: enable interrupt in interactive mode > > > > app/test-pmd/cmdline.c | 27 ++++++++++++++------------- > > app/test-pmd/testpmd.c | 11 +++++++++++ > > lib/cmdline/cmdline.h | 10 ++++++++++ > > lib/cmdline/cmdline_os_unix.c | 8 +++++++- > > lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- > > lib/cmdline/cmdline_private.h | 2 +- > > lib/cmdline/version.map | 3 +++ > > 7 files changed, 62 insertions(+), 17 deletions(-) > > > > This solution is adding new cmdline API for -rc3 and there are some > testpmd changes, > can it be possible to have a simple workaround specific to window for > this release and get this set for next release? Not really. cmdline_poll() is broken in several ways. Don't want to fix it or use it.